RESOLVED FIXED 4332
Fix WebCore+SVG compile breakage from 4313 
https://bugs.webkit.org/show_bug.cgi?id=4332
Summary Fix WebCore+SVG compile breakage from 4313
Eric Seidel (no email)
Reported 2005-08-08 01:40:30 PDT
Now that http://bugzilla.opendarwin.org/show_bug.cgi?id=4313 is landed, kdom and friends are broken. This needs to be fixed.
Attachments
This patch fixes most of the issues, but not all.... yet. (639.08 KB, patch)
2005-08-08 01:41 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Should be a complete fix. (640.07 KB, patch)
2005-08-08 02:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Final patch. (640.23 KB, patch)
2005-08-08 11:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Adding call -> callFunction() change per darin's suggestion. (641.33 KB, patch)
2005-08-08 13:12 PDT, Eric Seidel (no email) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-08-08 01:41:28 PDT
Created attachment 3276 [details] This patch fixes most of the issues, but not all.... yet.
Eric Seidel (no email)
Comment 2 2005-08-08 02:22:37 PDT
Created attachment 3277 [details] Should be a complete fix. I'm off to bed. I'll run all the layout tests in the morning and commit.
Eric Seidel (no email)
Comment 3 2005-08-08 11:24:24 PDT
Created attachment 3281 [details] Final patch.
Eric Seidel (no email)
Comment 4 2005-08-08 11:27:01 PDT
Comment on attachment 3281 [details] Final patch. Fixes WebCore+SVG to build again. This patch shouldn't really need review, since it's a build-fix, only affects kdom/ksvg2, and is doing the exact same thing as darin's 4313. However you now know about it if you care to comment. Unless anyone objects, I'll commit it later on.
Darin Adler
Comment 5 2005-08-08 11:38:53 PDT
Comment on attachment 3281 [details] Final patch. The call functions also have to be updated to use the new name, callAsFunction.
Eric Seidel (no email)
Comment 6 2005-08-08 13:12:09 PDT
Created attachment 3283 [details] Adding call -> callFunction() change per darin's suggestion.
Eric Seidel (no email)
Comment 7 2005-08-08 13:13:17 PDT
Comment on attachment 3283 [details] Adding call -> callFunction() change per darin's suggestion. Again, I'll wait a bit to see if anyone has further comments, then will commit. All test SVG layout tests pass.
Darin Adler
Comment 8 2005-08-08 13:23:37 PDT
Comment on attachment 3283 [details] Adding call -> callFunction() change per darin's suggestion. Looks fine -- best if there was a way to test this, tho; Eric says we can't test because of the JavaScript slot change.
Note You need to log in before you can comment on or make changes to this bug.