WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
4325
Mozilla Date tests have an unnecessary loop that runs 1970 times before each test
https://bugs.webkit.org/show_bug.cgi?id=4325
Summary
Mozilla Date tests have an unnecessary loop that runs 1970 times before each ...
Darin Adler
Reported
2005-08-07 18:25:58 PDT
There's code to compute the value of "year 0" in all the Mozilla date tests. There's no need to compute this on entry to each test. This is not all of why the tests are slow, but it's at least part of it.
Attachments
patch to use "year 0" constant instead of computing it each time
(52.74 KB, patch)
2005-08-07 18:26 PDT
,
Darin Adler
sullivan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2005-08-07 18:26:59 PDT
Created
attachment 3271
[details]
patch to use "year 0" constant instead of computing it each time
John Sullivan
Comment 2
2005-08-08 09:08:55 PDT
Comment on
attachment 3271
[details]
patch to use "year 0" constant instead of computing it each time looks good
Geoffrey Garen
Comment 3
2005-08-08 10:29:07 PDT
I'm pretty sure the rest of the slowness can be corrected by similar fixes -- turning repeated calculations into constants. The date tests are pretty pedantic in how they calculate correct answers.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug