Bug 4313 - eliminate KJS::Value and KJS::Object smart pointer wrappers (for simplicity and speed)
Summary: eliminate KJS::Value and KJS::Object smart pointer wrappers (for simplicity a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Enhancement
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-06 21:31 PDT by Darin Adler
Modified: 2006-03-15 07:12 PST (History)
0 users

See Also:


Attachments
patch to remove the wrappers as of today (928.34 KB, patch)
2005-08-06 22:02 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
patch, revised to work after Maciej's PropertySlot change (931.19 KB, patch)
2005-08-07 18:23 PDT, Darin Adler
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2005-08-06 21:31:07 PDT
Now that we don't get any benefit from the smartness of the KJS::Value and KJS::Object smart pointer 
classes, we should remove them.

This will make the API better since it will remove the ambiguity about when to use ValueImp and when to 
use Value, and it will also should make things a little faster.
Comment 1 Darin Adler 2005-08-06 22:02:52 PDT
Created attachment 3251 [details]
patch to remove the wrappers as of today

Here's the patch as of this moment. I know I'll have to redo a lot of it once
Maciej lands what he's currently working on.
Comment 2 Darin Adler 2005-08-07 18:23:20 PDT
Created attachment 3270 [details]
patch, revised to work after Maciej's PropertySlot change
Comment 3 Darin Adler 2005-08-07 20:18:09 PDT
My performance measurement today shows a 2% speedup in iBench JavaScript with this change. Earlier 
tests did not show a speed-up, so this is welcome news. Hooray!
Comment 4 Maciej Stachowiak 2005-08-07 20:59:50 PDT
Comment on attachment 3270 [details]
patch, revised to work after Maciej's PropertySlot change

rs=me
Comment 5 David Kilzer (:ddkilzer) 2006-03-15 07:12:36 PST
NOTE: This bug also fixed Bug 4059.