RESOLVED FIXED 4310
"sheet" method is unimplemented in Obj-C DOM API 
https://bugs.webkit.org/show_bug.cgi?id=4310
Summary "sheet" method is unimplemented in Obj-C DOM API
Darin Adler
Reported 2005-08-06 20:19:16 PDT
There's a sheet method declared but not implemented in the Objective-C DOM wrappers.
Attachments
patch to implement the method (1.82 KB, patch)
2005-08-06 20:20 PDT, Darin Adler 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-08-06 20:20:08 PDT
Created attachment 3247 [details] patch to implement the method
John Sullivan
Comment 2 2005-08-08 09:25:24 PDT
Comment on attachment 3247 [details] patch to implement the method Patch looks good, but needs some sort of testing. r=me if you find a way to test it.
Eric Seidel (no email)
Comment 3 2005-09-17 14:57:48 PDT
Comment on attachment 3247 [details] patch to implement the method Looks great. (this code actually benifits from the odd behavior of the last patch, in that it will "correctly" return a DOMCSSStyleSheet or DOMStyleSheet depending on the impl.) r=me
Eric Seidel (no email)
Comment 4 2005-09-18 14:44:45 PDT
As ggaren correctly points out, all of these really should have layout tests. For better or worse I ignored that fact, realizing that we don't currently (AFAIK) have any way of testing the Obj-C DOM API. I talked with andersca a bit on IRC, he said he started the py-objc Obj-C DOM testing system, but hasn't finished yet.
Darin Adler
Comment 5 2005-09-23 11:20:16 PDT
Note that the "odd behavior" that Eric mentions here is the design of the DOM wrappers. The class of the Objective-C DOM wrapper mirrors the class of the actual DOM object it's wrapping. That way you can use standard Objective-C techniques like "isKindOfClass:" and downcasting on the wrappers.
Note You need to log in before you can comment on or make changes to this bug.