RESOLVED FIXED 4280
Would be nice if webkitdirs.pm could check system/xcode version
https://bugs.webkit.org/show_bug.cgi?id=4280
Summary Would be nice if webkitdirs.pm could check system/xcode version
Eric Seidel (no email)
Reported 2005-08-03 23:33:39 PDT
It would be nice if webkitdirs.pm could check system/xcode version. For example, a dev complained tonight that xcode wasn't building, with this log: localhost:~ user$ WebKitTools/Scripts/build-webkit xcodebuild: Error: the project name JavaScriptCore.xcodeproj does not have a valid extension. It would have been nice if we had checked the version info and printed something like "You need at least Xcode 2.1 installed to build WebKit", perhaps even provided a URL: http://developer.apple.com/ tools/xcode This would be pretty easy to do using "xcodebuild -version" and a bit of regex. Maybe I'll do that right now. ;-)
Attachments
A patch to make build-* scripts check os & xcode version (3.40 KB, patch)
2005-08-03 23:56 PDT, Eric Seidel (no email)
no flags
Patch to add checking Xcode & OS X version to build-* scripts. (3.79 KB, patch)
2005-08-04 00:09 PDT, Eric Seidel (no email)
darin: review+
Eric Seidel (no email)
Comment 1 2005-08-03 23:56:45 PDT
Created attachment 3220 [details] A patch to make build-* scripts check os & xcode version
Eric Seidel (no email)
Comment 2 2005-08-04 00:09:53 PDT
Created attachment 3222 [details] Patch to add checking Xcode & OS X version to build-* scripts.
Darin Adler
Comment 3 2005-08-04 11:22:23 PDT
Comment on attachment 3222 [details] Patch to add checking Xcode & OS X version to build-* scripts. This: if (substr($buildVersion, 0, 1) < 8) should just be $buildVersion < 8. The current version won't work for 10, for example, and there's no reason to go out of the way to do substr. But this looks fine, r=me.
Note You need to log in before you can comment on or make changes to this bug.