Bug 4280 - Would be nice if webkitdirs.pm could check system/xcode version
Summary: Would be nice if webkitdirs.pm could check system/xcode version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Enhancement
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-03 23:33 PDT by Eric Seidel (no email)
Modified: 2005-08-06 01:58 PDT (History)
0 users

See Also:


Attachments
A patch to make build-* scripts check os & xcode version (3.40 KB, patch)
2005-08-03 23:56 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch to add checking Xcode & OS X version to build-* scripts. (3.79 KB, patch)
2005-08-04 00:09 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-08-03 23:33:39 PDT
It would be nice if webkitdirs.pm could check system/xcode version.

For example, a dev complained tonight that xcode wasn't building, with this log:

localhost:~ user$  WebKitTools/Scripts/build-webkit
xcodebuild: Error: the project name JavaScriptCore.xcodeproj does not have a valid extension.

It would have been nice if we had checked the version info and printed something like "You need at 
least Xcode 2.1 installed to build WebKit", perhaps even provided a URL: http://developer.apple.com/
tools/xcode

This would be pretty easy to do using "xcodebuild -version" and a bit of regex.

Maybe I'll do that right now. ;-)
Comment 1 Eric Seidel (no email) 2005-08-03 23:56:45 PDT
Created attachment 3220 [details]
A patch to make build-* scripts check os & xcode version
Comment 2 Eric Seidel (no email) 2005-08-04 00:09:53 PDT
Created attachment 3222 [details]
Patch to add checking Xcode & OS X version to build-* scripts.
Comment 3 Darin Adler 2005-08-04 11:22:23 PDT
Comment on attachment 3222 [details]
Patch to add checking Xcode & OS X version to build-* scripts.

This:

    if (substr($buildVersion, 0, 1) < 8)

should just be $buildVersion < 8. The current version won't work for 10, for
example, and there's no reason to go out of the way to do substr.

But this looks fine, r=me.