Bug 4153 - WebKit page cache can grow without bound when there is a snapback item around
Summary: WebKit page cache can grow without bound when there is a snapback item around
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-26 22:50 PDT by Maciej Stachowiak
Modified: 2005-07-30 12:38 PDT (History)
0 users

See Also:


Attachments
the fix (2.32 KB, patch)
2005-07-26 22:58 PDT, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
again, without the debug printfs (2.20 KB, patch)
2005-07-26 23:04 PDT, Maciej Stachowiak
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2005-07-26 22:50:32 PDT
When a snapback page is set, the WebKit back/forward cache (AKA page cache) can grow without bound, 
because it will find the oldest back/forward item but will refuse to actually purge it since it is marked as 
the snapback item. A simple fix would be to purge the most recent non-snapback item when the page 
cache goes over its maximum size instead.
Comment 1 Maciej Stachowiak 2005-07-26 22:58:18 PDT
Created attachment 3106 [details]
the fix
Comment 2 Maciej Stachowiak 2005-07-26 23:04:34 PDT
Created attachment 3107 [details]
again, without the debug printfs

Whoops, I left debug code in the last patch.
Comment 3 Dave Hyatt 2005-07-27 22:50:15 PDT
Comment on attachment 3107 [details]
again, without the debug printfs

r=me
Comment 4 Darin Adler 2005-07-30 12:38:32 PDT
Maciej landed this fix a few days ago.