Bug 4128 – !important is ignored in inline styling.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Tim Brown]

Safari not recognizing inline background-images with !important attribute.

In the link provided, every web-standards browser I've tested shows a busy blue
background-image behind the H4.  NN4 shows no background image, which I was
aiming for.  Safari 10.4 also shows no background-image, but I want it to.

Thank you very much,
Tim Brown

[Chris Petersen]

Confirming with TOT WebKit and Safari 2.0 (412.2).

[Mark Rowe (bdash)]

Marking as confirmed as per Chris Petersen's comment.

[Eric Seidel (no email)]

I don't know quite enough about the CSS code to fix this w/o some investigation, but it should be a pretty 
trivial fix for someone who does.  Somehow backgrounds are not respecting the !important flag.  It woudl 
be nice to have an even nicer test case (one we could actually land as part of the layout tests)

[Joost de Valk (AlthA)]

Will add a testcase that shows. Changing summary and keyword.

[Joost de Valk (AlthA)]

Created attachment 5327 [details]
Testcase

This shows that inline !important is being ignored.

[Matt Lilek]

*** Bug 11688 has been marked as a duplicate of this bug. ***

[Rob Buis]

Created attachment 13271 [details]
First attempt

This patch should do it. I'll make another patch that may be more efficient.
Cheers,

Rob.

[Dave Hyatt]

Comment on attachment 13271 [details]
First attempt

Since the # of properties is typically going to be small in a given declaration, I doubt the performance of this will be a big deal.

One idea, though, if it does turn out to be a problem, might be to cache whether the decl has any !important rules used in it at all.  Only if it contains some do you do the slower check.

[Dave Hyatt]

Comment on attachment 13271 [details]
First attempt

r=me

[Rob Buis]

Landed in r19892.

[Dave Hyatt]

Rob, could you file a followup bug to improve the performance of this? Thanks!