RESOLVED FIXED 4101
CSS Fibonacci spiral using 4 images doesn't render correctly 
https://bugs.webkit.org/show_bug.cgi?id=4101
Summary CSS Fibonacci spiral using 4 images doesn't render correctly
David Storey
Reported 2005-07-21 13:17:19 PDT
the CSS Fibonacci spiral using images does not render correctly in WebKit. The pure CSS version works correctly. The spiral works in Gecko, Opera and IE/Mac
Attachments
Test case (261 bytes, text/html)
2005-09-09 13:51 PDT, Patrick Geiller 		no flags
Details
2 line patch (953 bytes, patch)
2005-12-11 19:38 PST, Sam Weinig 		mjs: review-
DetailsFormatted DiffDiff
patch 2 (2.29 KB, patch)
2005-12-15 10:48 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
testcase (912 bytes, text/html)
2005-12-15 10:50 PST, Sam Weinig 		no flags
Details
patch 3 (2.68 KB, patch)
2005-12-22 15:42 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
patch 4 (3.51 KB, patch)
2005-12-22 20:17 PST, Sam Weinig 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2005-07-22 16:26:08 PDT
I see the bad rendering also, compared to Firefox, so confirming.
Patrick Geiller
Comment 2 2005-09-09 13:51:08 PDT
Created attachment 3828 [details] Test case The spiral uses absolute-positioned images having only their width specified. Safari loses the aspect ratio this way.
Sam Weinig
Comment 3 2005-12-11 19:38:51 PST
Created attachment 5045 [details] 2 line patch
Eric Seidel (no email)
Comment 4 2005-12-11 19:54:50 PST
Comment on attachment 5045 [details] 2 line patch FYI, this may affect SVG (I'm not sure) as KCanvasContainer answers "true" to isReplaced(), yet it does not subclass from RenderReplaced. Just thought you'd like to know.
Maciej Stachowiak
Comment 5 2005-12-13 22:07:10 PST
The patch looks good to me, but please make the following changes to comply with the WebKit patch submission guidelines: - add your copyright notice to the file - include the test case in the patch - provide a ChangeLog entry (the prepare-ChangeLog script can do this for you)
Sam Weinig
Comment 6 2005-12-15 10:48:40 PST
Created attachment 5095 [details] patch 2 I am not quite sure if this is correct yet. I couldn't figure out how to have the script notice the new test case so I am uploading it seperatly.
Sam Weinig
Comment 7 2005-12-15 10:50:38 PST
Created attachment 5096 [details] testcase
Sam Weinig
Comment 8 2005-12-22 15:42:27 PST
Created attachment 5228 [details] patch 3 Now all in one nice patch.
Sam Weinig
Comment 9 2005-12-22 20:17:37 PST
Created attachment 5235 [details] patch 4 damn, now with ChangeLog
Maciej Stachowiak
Comment 10 2005-12-22 22:53:06 PST
Comment on attachment 5228 [details] patch 3 withdrawing review from old patch since I r+'d the newer one.
Note You need to log in before you can comment on or make changes to this bug.