Bug 4087 – Fixes function.cpp for Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Justin Haygood]

Fixes function.cpp for Windows, including enabling ICU support.

[Justin Haygood]

Created attachment 3034 [details]
Enables ICU, etc..

Enables ICU for Windows, etc..

[Darin Adler]

Comment on attachment 3034 [details]
Enables ICU, etc..

This HAVE_ICU logic should be moved to <config.h> so it doesn't have to be in
every single file.

In fact, I think we can just assume ICU -- we don't really need the non-ICU
code path in JavaScriptCore.

Either way, this patch should be fixed.

[Justin Haygood]

(In reply to comment #2)
> (From update of attachment 3034 [details] [edit])
> This HAVE_ICU logic should be moved to <config.h> so it doesn't have to be in
> every single file.
> 
> In fact, I think we can just assume ICU -- we don't really need the non-ICU
> code path in JavaScriptCore.
> 
> Either way, this patch should be fixed.
> 

I'll fix it, wiping out the non ICU codepaths. Thank you though. That was what I
 **really** wanted to do, but just wanted to play it safe.

[Justin Haygood]

Created attachment 3050 [details]
Assumes ICU throughout

Assumes that we have ICU everywhere.

[Maciej Stachowiak]

Comment on attachment 3050 [details]
Assumes ICU throughout

r=me but I don't think this comment is really needed:

+// Assume ICU

[Darin Adler]

Sorry, these were sitting around in UNCONFIRMED so I didn't notice them. Landing them now.