Bug 4085 - Modify config.h to have options for Windows
Summary: Modify config.h to have options for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 3356
  Show dependency treegraph
 
Reported: 2005-07-20 15:18 PDT by Justin Haygood
Modified: 2005-08-31 00:55 PDT (History)
0 users

See Also:


Attachments
Adds Windows options (1.07 KB, patch)
2005-07-20 15:19 PDT, Justin Haygood
darin: review-
Details | Formatted Diff | Diff
Same changes as before, but consistent, and has HAVE_ICU (1.08 KB, patch)
2005-07-22 10:50 PDT, Justin Haygood
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Haygood 2005-07-20 15:18:35 PDT
config.h needs to work on Windows. Patch to fix being attached to this bug.
Comment 1 Justin Haygood 2005-07-20 15:19:02 PDT
Created attachment 3032 [details]
Adds Windows options

Provides HAVE_BLABLABLA options for Windows
Comment 2 Justin Haygood 2005-07-20 15:19:54 PDT
Comment on attachment 3032 [details]
Adds Windows options

Adds Windows options to config.h
Comment 3 Darin Adler 2005-07-21 13:08:55 PDT
Comment on attachment 3032 [details]
Adds Windows options

This mixes "#ifndef WIN32" with #if WIN32". Should be made consistent.

Otherwise, looks fine to me.
Comment 4 Justin Haygood 2005-07-22 10:50:09 PDT
Created attachment 3054 [details]
Same changes as before, but consistent, and has HAVE_ICU

Makes changes recommended to other bugs, and makes the WIN32 #ifs consistent.
Comment 5 Darin Adler 2005-07-22 23:05:19 PDT
Comment on attachment 3054 [details]
Same changes as before, but consistent, and has HAVE_ICU

Looks good. I'd prefer "#if !WIN32" to "#if! WIN32", but that's a nit at this
point; we should land it.
Comment 6 Darin Adler 2005-08-31 00:55:21 PDT
Sorry, these were sitting around in UNCONFIRMED so I didn't notice them. Landing them now.