Bug 3992 - some elements draw selection when printing
Summary: some elements draw selection when printing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Trey Matteson
URL: http://www.nytimes.com/
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-13 22:05 PDT by Trey Matteson
Modified: 2005-07-26 19:09 PDT (History)
0 users

See Also:

Attachments
proposed patch (4.29 KB, patch)
2005-07-13 22:13 PDT, Trey Matteson 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trey Matteson 2005-07-13 22:05:30 PDT 
Go to nytimes.com.  Select All.  Print.  Choose Preview.

The printing output has a large amount of the selection gray drawn all over it.  The text elements seem 
smart enough not to draw selection, but the stuff between the text is all gray.

Might be a regression from 1.2, but I'm not positive.
Comment 1 Trey Matteson 2005-07-13 22:05:56 PDT 
This is also Radar #4083496
Comment 2 Trey Matteson 2005-07-13 22:13:40 PDT 
Created attachment 2957 [details]
proposed patch
Comment 3 Dave Hyatt 2005-07-25 14:34:04 PDT 
Comment on attachment 2957 [details]
proposed patch

r=me

It does occur to me, though, that another way to fix this might be to simply
not do the PaintActionSelection phase at all when printing.  Then none of the
code that paints selection in the individual renderobjects would even have to
check the printing state.
Comment 4 Justin Garcia 2005-07-26 19:09:36 PDT 
Landing this