Bug 3991 - JSC doesn't implement Array.prototype.toLocaleString()
Summary: JSC doesn't implement Array.prototype.toLocaleString()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-13 18:25 PDT by Geoffrey Garen
Modified: 2005-08-15 21:11 PDT (History)
1 user (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2005-07-13 18:27 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (1.52 KB, patch)
2005-07-13 18:32 PDT, Geoffrey Garen
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2005-07-13 18:25:34 PDT
ECMA spec:
15.4.4.3 Array.prototype.toLocaleString()

The elements of the array are converted to strings using their toLocaleString methods, and these strings 
are then concatenated, separated by occurrences of a separator string that has been derived in an 
implementation-defined locale-specific way. The result of calling this function is intended to be analogous 
to the result of toString, except that the result of this function is intended to be locale-specific.
Comment 1 Geoffrey Garen 2005-07-13 18:26:23 PDT
Causes the following failure:
        ecma_3/Array/15.4.4.3-1.js
Comment 2 Geoffrey Garen 2005-07-13 18:27:41 PDT
Created attachment 2955 [details]
Patch

Fix.

I think our case structure in this and other code is pretty ugly. Worth
redoing?
Comment 3 Geoffrey Garen 2005-07-13 18:32:51 PDT
Created attachment 2956 [details]
Patch

Oops. Last patch had extra changes that were lingering in my tree.
Comment 4 Oliver Hunt 2005-07-13 23:58:05 PDT
If this gets landed can a comment be put in with bug 3539 as its patch will need to be updated work with 
this patch
Comment 5 Maciej Stachowiak 2005-07-19 14:04:53 PDT
Comment on attachment 2956 [details]
Patch

r=me