Bug 39799 - Update the block of characters that need to go to complex script path
Summary: Update the block of characters that need to go to complex script path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jungshik Shin
URL: http://ja.wikipedia.org/wiki/JIS_X_02...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-26 17:20 PDT by Jungshik Shin
Modified: 2011-05-03 22:06 PDT (History)
4 users (show)

See Also:


Attachments
test file (235 bytes, text/html)
2010-05-27 16:57 PDT, Jungshik Shin
no flags Details
patch (layout test without expected results, change log) (5.21 KB, patch)
2010-07-12 17:16 PDT, Jungshik Shin
no flags Details | Formatted Diff | Diff
updated patch (to Unicode 6.0) (7.06 KB, patch)
2011-04-18 22:31 PDT, Jungshik Shin
no flags Details | Formatted Diff | Diff
patch with layout test and result (9.12 KB, patch)
2011-04-19 17:19 PDT, Jungshik Shin
no flags Details | Formatted Diff | Diff
updated patch with style nits fixed (9.15 KB, patch)
2011-04-19 17:28 PDT, Jungshik Shin
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jungshik Shin 2010-05-26 17:20:50 PDT
The list of blocks of Unicode characters that require complex script code path is outdated. 
In addition, it does not include [U+02E5, U+02E9] (IPA tone letters). They're not combining, but some sequences of those characters require mandatory ligation. 

See  Unicode 5.2 section 7.8 Modifier letters (p.224: Tone letters Figure 
7-7) http://www.unicode.org/versions/Unicode5.2.0/ch07.pdf (p. 27 in the 
PDF). 

My preliminary patch is up at http://codereview.chromium.org/2241005/show

I'll upload it here along with a layout test (if I can make one with a commonly available font on each platform). 

It's a Chromium bug ( http://crbug.com/45013) initially filed as a Chromium OS bug (  http://crosbug.com/3122 )
Comment 1 Jungshik Shin 2010-05-27 16:57:16 PDT
Created attachment 57282 [details]
test file

Lines 2 - 6 contain sequences of IPA tone letters that have to be ligated instead of being rendered separately.
Comment 2 Jungshik Shin 2010-07-12 17:16:42 PDT
Created attachment 61297 [details]
patch (layout test without expected results, change log)

Just to stow away my patch and layout test. Not for review, yet.
Comment 3 Jungshik Shin 2011-04-18 22:31:51 PDT
Created attachment 90148 [details]
updated patch (to Unicode 6.0) 

Updated the patch to list all the 'complex script blocks' in Unicode 6.0. I'll generate the layout test results tomorrow and update the patch again. (at the moment, remote connections to Win/Mac do not work well).
Comment 4 Jungshik Shin 2011-04-19 17:19:35 PDT
Created attachment 90277 [details]
patch with layout test and result
Comment 5 WebKit Review Bot 2011-04-19 17:22:10 PDT
Attachment 90277 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Jungshik Shin 2011-04-19 17:28:36 PDT
Created attachment 90278 [details]
updated patch with style nits fixed
Comment 7 Adam Barth 2011-04-19 17:31:48 PDT
Comment on attachment 90278 [details]
updated patch with style nits fixed

rs=me
Comment 8 Simon Fraser (smfr) 2011-05-03 22:06:55 PDT
This test is failing on Mac SnowLeopard for me:
"FAIL: The following strings are rendered differently depending on what text-rendering is set to : ˥˧˥"