Bug 3971 – JS test suite depends on JS 1.2 behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Geoffrey Garen]

The JS test suite attempts to use version() to travel back to the days of JS 1.2 and test for behaviors that 
are directly contradictory to the ECMA3 spec. Since we only support JS 1.5/ECMA3, and since version() is 
only a dummy function in our code, some tests raise false positives.

Test failures:
        js1_2/Array/tostring_1.js
        js1_2/Array/tostring_2.js

[Geoffrey Garen]

Created attachment 2935 [details]
Patch

This patch makes the tests expect JS 1.5 results.

[Darin Adler]

Comment on attachment 2935 [details]
Patch

I'd like the change to the tests to at least document what's going on rather
than simply commenting out the code.

When we get new versions of the JS test suite, we may need to merge this change
in, and it would be good to make sure it's "self-documenting".

I must admit I don't entirely understand why removing this code completely is
the best fix, but I think a comment explaining why would probably convince me.

[Geoffrey Garen]

Created attachment 2991 [details]
Patch

Updated patch to include comment.