WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
3953
back-forward items have wrong titles after sub-frame navigations
https://bugs.webkit.org/show_bug.cgi?id=3953
Summary
back-forward items have wrong titles after sub-frame navigations
Trey Matteson
Reported
2005-07-11 12:03:36 PDT
Goto
http://java.sun.com/j2se/1.5.0/docs/api/index.html
. Note the title is "Overview...". Now click some class names in the lower left pane. Press and hold the back button. The oldest item that should still be "Overview..." is now titled the same as the last class page that was loaded. At the HTML level, what's happening is that whenever a frame loads it sets the parent.document.title to be specific to that newly loaded frame. The same is also true for the history item for the overview page - its title also changes as the page changes its title dynamically. I don't think this is very desirable behavior from the user perspective, but given the page keeps changing it's title, it's not as clear to me that this is technically incorrect.
Attachments
patch for bug 3953
(9.46 KB, patch)
2005-07-11 16:52 PDT
,
Trey Matteson
sullivan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Trey Matteson
Comment 1
2005-07-11 12:46:51 PDT
I checked WinIE, and they do not allow the title of the history item to change due to subsequent loads, **while the window is open **. When you open a new window and look at history, then the item has the newly requested title. So perhaps they let the items title change, but just don't have any way to track that change dynamically in their history UI.
Trey Matteson
Comment 2
2005-07-11 16:52:02 PDT
Created
attachment 2912
[details]
patch for
bug 3953
John Sullivan
Comment 3
2005-07-11 17:25:53 PDT
Comment on
attachment 2912
[details]
patch for
bug 3953
Looks very good to me (bug fix plus code simplfication, yay!). Whoever commits this should verify that it fixes the specific bug reported here (the oldest title in the Back button's menu should be Overview after the fix).
Justin Garcia
Comment 4
2005-07-24 16:15:29 PDT
Landed this patch, and verified fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug