Bug 3893 - -[DOMCSSStyleDeclaration cssText] is not implemented
Summary: -[DOMCSSStyleDeclaration cssText] is not implemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
: 6359 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-07-07 11:00 PDT by Dan Wood
Modified: 2019-05-02 16:23 PDT (History)
2 users (show)

See Also:

Attachments
Implement cssText for most rules (9.22 KB, patch)
2005-07-08 21:19 PDT, Anders Carlsson 		hyatt: review-
Details | Formatted Diff | Diff
Address comments (9.60 KB, patch)
2005-07-12 03:45 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Wood 2005-07-07 11:00:51 PDT 
The underlying implementation of -[DOMCSSStyleDeclaration cssText] is not implemented.

Test case.... Take a node and ask for its style, then print it out.
	DOMCSSStyleDeclaration *style = [[self DOMDocument] getComputedStyle:(DOMElement *)
node :@""];
	
	NSLog(@"cssText = %@", [style cssText]);

Result:
=================
ERROR: unimplemented
(/Volumes/dwood/dev/WK/WebCore/khtml/css/css_computedstyle.cpp:289 virtual DOM::DOMString 
DOM::CSSComputedStyleDeclarationImpl::cssText() const)
=================

Here is the offending code, in css_computedstyle.cpp:
DOMString CSSComputedStyleDeclarationImpl::cssText() const
{
    ERROR("unimplemented");
    return DOMString();
}
Comment 1 Anders Carlsson 2005-07-08 21:19:23 PDT 
Created attachment 2875 [details]
Implement cssText for most rules
Comment 2 Dave Hyatt 2005-07-09 14:11:24 PDT 
The cpp file uses namespace DOM so no need for DOM::DOMString there.  Can you attach a new patch 
that minimizes the extra DOM::? Thanks.
Comment 3 Anders Carlsson 2005-07-12 03:45:48 PDT 
Created attachment 2921 [details]
Address comments
Comment 4 Darin Adler 2005-07-18 07:59:27 PDT 
Comment on attachment 2921 [details]
Address comments

It's a little annoying that CSSComputedStyleDeclarationImpl::cssText returns
something with a trailing space.

Is there some better way to share the getPropertyName function than putting
this extern declaration in the .cpp file?

The test looks good to me.

I'm going to mark this review+ even though I have those two minor
questions/comments above.
Comment 5 mitz 2006-02-18 11:53:33 PST 
*** Bug 6359 has been marked as a duplicate of this bug. ***