Bug 3825 - GW: need a KWQTimer with QTimer(parent) support
Summary: GW: need a KWQTimer with QTimer(parent) support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency treegraph
 
Reported: 2005-07-02 20:30 PDT by Eric Seidel (no email)
Modified: 2005-07-03 16:30 PDT (History)
0 users

See Also:


Attachments
adds QTimer(parent) support (1.22 KB, patch)
2005-07-02 20:31 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-07-02 20:30:02 PDT
This is a temporary solution to allow compiling.  Any code which actually depends on this method will log 
to the console.  Before shipping code depending on QTimer(parent) we would need to actually make these 
timers destruct when their parent objects do.
Comment 1 Eric Seidel (no email) 2005-07-02 20:31:57 PDT
Created attachment 2764 [details]
adds QTimer(parent) support
Comment 2 Maciej Stachowiak 2005-07-03 03:16:37 PDT
Comment on attachment 2764 [details]
adds QTimer(parent) support

r=me

*but*, the side effect could be a lot worse than a leak if this is really used
- it could lead to incorrect behavior or a crash if the timer fires after it's
expected to be gone.
Comment 3 Eric Seidel (no email) 2005-07-03 16:30:49 PDT
landed with better log message:

if (parent) LOG(NotYetImplemented, "Parent pointer ignored.  QTimer will be 
leaked and may fire after parent dealloc causing crash.");