Bug 3774 – do renaming so that loaders are called "loader", not "client" or "delegate"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

I am planning on renaming the following classes, source files, and methods in WebKit:

    WebBaseResourceHandleDelegate -> WebLoader
    WebMainResourceClient -> WebMainResourceLoader
    WebSubresourceClient -> WebSubresourceLoader
    WebNetscapePluginConnectionDelegate -> WebNetscapePlugInStreamLoader
    subresourceClients -> subresourceLoaders
    mainClient -> mainResourceLoader
    plugInStreamClients -> plugInStreamLoaders
    _addSubresourceClient -> _addSubresourceLoader
    _removeSubresourceClient -> _removeSubresourceLoader
    _addPlugInStreamClient -> _addPlugInStreamLoader
    _removePlugInStreamClient -> _removePlugInStreamLoader

[Darin Adler]

Created attachment 2715 [details]
Patch, including deleting files; best applied with cvs-apply

I went to the cvs server and copied the files that need renaming. This patch
now does a cvs rm on the now-obsolete files and patches all the code, including
the project, to use the new names.

Also, it fixes some patches in the WebKit project file to be group-relative and
removes one unneeded framework path. But that's all -- just the renaming and
the project file tweaks. I've compiled and tested running Safari and layout
tests.

[Darin Adler]

Comment on attachment 2715 [details]
Patch, including deleting files; best applied with cvs-apply

This patch is simply renaming -- I considered landing it without review and
decided it would be better to get patch review.

It's a bit time-critical because we have "doubled" files in the repository due
to the "copy files on the CVS server" technique we use for renaming files in
CVS.

[John Sullivan]

Comment on attachment 2715 [details]
Patch, including deleting files; best applied with cvs-apply

Good name change. I see that this doesn't affect any public headers, so r=me. I
am assuming that you tested Safari in some simple way.

[Eric Seidel (no email)]

Comment on attachment 2715 [details]
Patch, including deleting files; best applied with cvs-apply

It's too bad webkit isn't using svn quite yet... or the rename of files would
have been directly supported.  Also glad to see that this is in WK and not in
WC where a rename would have further differenced us from KDE.