Bug 3771 - GW: Update create_hash_table closer to TOT KJS
Summary: GW: Update create_hash_table closer to TOT KJS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency treegraph
 
Reported: 2005-06-30 02:34 PDT by Eric Seidel (no email)
Modified: 2005-07-01 03:03 PDT (History)
0 users

See Also:


Attachments
relatively simple patch, which adds support to create_hash_table as detailed in the bug (4.21 KB, patch)
2005-06-30 02:36 PDT, Eric Seidel (no email)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-06-30 02:34:51 PDT
This update brings support for the
-n <namespace>
addition as part of KDOM

This also (more importantly) adds support for for parsing more recent hashtable comments (w/o affecting 
support for exiting comments).

The only change left to merge into this file form TOT KJS is support for the separate "string tables" lookup 
for better hashtable memory locality (and possibly perf improvements.  That merger will have to be 
covered by another bug.
Comment 1 Eric Seidel (no email) 2005-06-30 02:36:09 PDT
Created attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug
Comment 2 Eric Seidel (no email) 2005-06-30 03:04:31 PDT
Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug

verified all test cases pass
Comment 3 Darin Adler 2005-06-30 08:23:09 PDT
Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug

I'd prefer to roll in the "string tables" change at the same time, myself.

I'm also not fond of comments that say "NEW", since they inevitably become
"OLD" :-)

I also don't like checking in commented-out debugging code.

And it's very strange to use this:

    ".$nameEntries."

when you one could just have said:

    $nameEntries

But these are minor quibbles -- seems fine to land this.
Comment 4 Eric Seidel (no email) 2005-07-01 03:03:51 PDT
I removed the "NEW: " comment when committing.