Bug 3670 - GW: Add remove and byteOrderMark support to KWQString for kdom
Summary: GW: Add remove and byteOrderMark support to KWQString for kdom
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P3 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 3250
  Show dependency tree / graph
 
Reported: 2005-06-23 02:20 PDT by Eric Seidel (no email)
Modified: 2005-07-03 16:21 PDT (History)
0 users

See Also:

Attachments
Adds remove() and byteOrderMark support to KWQString (1.16 KB, patch)
2005-06-23 02:26 PDT, Eric Seidel (no email) 		darin: review-
Details | Formatted Diff | Diff
Formatting oversights now fixed. (1.12 KB, patch)
2005-06-23 09:18 PDT, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2005-06-23 02:20:54 PDT 
Add remove and byteOrderMark support to KWQString for kdom
Comment 1 Eric Seidel (no email) 2005-06-23 02:26:05 PDT 
Created attachment 2574 [details]
Adds remove() and byteOrderMark support to KWQString

I'm not entirely sure about the byteOrderMark stuff, I'm not a unicode
expert... The remove stuff should be just fine.
Comment 2 Eric Seidel (no email) 2005-06-23 02:26:46 PDT 
Comment on attachment 2574 [details]
Adds remove() and byteOrderMark support to KWQString

Either way, this code is well tested, and seems to work fine for me ;-)
Comment 3 Darin Adler 2005-06-23 07:08:23 PDT 
Comment on attachment 2574 [details]
Adds remove() and byteOrderMark support to KWQString

Formatting is incorrect in the definitions of "remove". There are extra spaces
before the "(" and ")" characters.

Also, there's no need for "this->" in the implenetations of those methods.
Comment 4 Eric Seidel (no email) 2005-06-23 09:18:50 PDT 
Created attachment 2588 [details]
Formatting oversights now fixed.
Comment 5 Darin Adler 2005-06-23 09:59:54 PDT 
Comment on attachment 2588 [details]
Formatting oversights now fixed.

r=me
Comment 6 Joost de Valk (AlthA) 2005-07-03 08:17:36 PDT 
Eric, could you confirm this one (too :) )?