Bug 3644 - Error string representation
Summary: Error string representation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 412
Hardware: Other Linux
: P2 Minor
Assignee: Carsten Guenther
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-22 02:31 PDT by Harri Porten
Modified: 2005-07-08 15:39 PDT (History)
0 users

See Also:


Attachments
One-line fix in error_object.cpp; updated expected.html (104.23 KB, patch)
2005-07-06 09:50 PDT, Carsten Guenther
no flags Details | Formatted Diff | Diff
Updated patch including fixed layout tests (110.72 KB, patch)
2005-07-06 10:34 PDT, Carsten Guenther
mjs: review+
Details | Formatted Diff | Diff
Updated expected.html (108.94 KB, text/html)
2005-07-08 13:20 PDT, Carsten Guenther
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harri Porten 2005-06-22 02:31:51 PDT
JSC regresses from the Mozilla string representation of Error objects. Use 
 
 document.write(Error("test")) 
 
to see the difference. It's tiny but it unnecessarily breaks the tests in 
15.11.1.1.js and 15.11.4.4-1.js in ecma_3/Exceptions of the Mozilla test suite. 
 
Just backed out from the JSC change I had applied on the weekend: 
http://websvn.kde.org/trunk/KDE/kdelibs/kjs/error_object.cpp?rev=427879&r1=426754&r2=427879
Comment 1 Joost de Valk (AlthA) 2005-06-23 10:00:40 PDT
confirming this one.
Comment 2 Carsten Guenther 2005-07-06 09:50:20 PDT
Created attachment 2832 [details]
One-line fix in error_object.cpp; updated expected.html
Comment 3 Carsten Guenther 2005-07-06 10:02:28 PDT
Comment on attachment 2832 [details]
One-line fix in error_object.cpp; updated expected.html

Cancelling. Needs to fix layout tests.
Comment 4 Carsten Guenther 2005-07-06 10:34:22 PDT
Created attachment 2833 [details]
Updated patch including fixed layout tests
Comment 5 Maciej Stachowiak 2005-07-06 20:09:53 PDT
Comment on attachment 2833 [details]
Updated patch including fixed layout tests

r=me
Comment 6 Vicki Murley 2005-07-08 11:38:06 PDT
Carson, I'm trying to commit your fix but it looks like the patch program is getting confused.  I suspect 
that lines in the updated test results that contain "-->" are to blame.  Could you attach your updated test 
results?  Thanks.
Comment 7 Carsten Guenther 2005-07-08 13:20:29 PDT
Created attachment 2869 [details]
Updated expected.html

Here it is.
Comment 8 Vicki Murley 2005-07-08 15:39:05 PDT
Silly me, I could have just generated my own expected.html file.  At any rate, I've committed this fix.