Bug 35321 - layout test dashboard json generator pulls the wrong webkit svn revision
Summary: layout test dashboard json generator pulls the wrong webkit svn revision
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-23 17:04 PST by Dirk Pranke
Modified: 2010-02-24 14:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2010-02-23 17:06 PST, Dirk Pranke 		eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-02-23 17:04:46 PST 
layout test dashboard json generator pulls the wrong webkit svn revision
Comment 1 Dirk Pranke 2010-02-23 17:06:17 PST 
Created attachment 49344 [details]
Patch
Comment 2 Dirk Pranke 2010-02-23 17:07:29 PST 
Ojan, can you take a look at this and make sure it looks right?
Comment 3 Ojan Vafai 2010-02-23 17:32:47 PST 
Comment on attachment 49344 [details]
Patch

Looks right to me. Nit: You might want to add to the ChangeLog description that we need to do this because Chromium doens't checkout the WebKit directory, just the subdirectories. That way it's in the revision history why we're getting the WebCore revision.
Comment 4 Dirk Pranke 2010-02-23 17:35:38 PST 
will do.
Comment 5 Eric Seidel (no email) 2010-02-24 12:24:16 PST 
Comment on attachment 49344 [details]
Patch

This could easily be moved to the (unit tested) scm.py module and suddenly support both git and svn repositories.

But this change as-is looks OK for now too.

cq- for ojan's nit.
Comment 6 Dirk Pranke 2010-02-24 14:48:17 PST 
Fix committed as r55202. Closing bug.