Bug 3436 - Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields]
Summary: Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822Header...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P1 Blocker
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-11 08:09 PDT by Stéphane Corthésy
Modified: 2005-06-22 09:34 PDT (History)
0 users

See Also:


Attachments
Patch to fix 3436 (1.12 KB, patch)
2005-06-20 22:21 PDT, Michael Gaiman
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Corthésy 2005-06-11 08:09:50 PDT
In WebKit/Misc.subproj/WebNSDataExtras.m version 1.4, method -[NSData(WebNSDateExtras) 
_webkit_parseRFC822HeaderFields] declared in corresponding header file is missing an implementation; 
actually implementation is there, but wrongly named -[NSData(WebNSDateExtras) 
_web_parseRFC822HeaderFields]
Simply renaming method fixes problem, as wrong method name is used nowhere in WebKit, whereas 
correct method name is.
BTW, shouldn't category be named WebNSDataExtras instead of WebNSDateExtras??
Comment 1 Michael Gaiman 2005-06-20 22:21:08 PDT
Created attachment 2522 [details]
Patch to fix 3436

This is a straightforward patch, but I figured if I did it, it might save
someone a couple minutes.
Comment 2 Darin Adler 2005-06-22 09:32:23 PDT
The "NSDate" typo in the header is the reason this wasn't caught at compile time. I'll fix that too.