Bug 3412 - Object.prototype is missing toLocaleString, isPrototypeOf and propertyIsEnumerable
Summary: Object.prototype is missing toLocaleString, isPrototypeOf and propertyIsEnume...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 412
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
: 3989 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-10 07:52 PDT by Mark Rowe (bdash)
Modified: 2005-07-14 10:42 PDT (History)
1 user (show)

See Also:


Attachments
Implementation of Object.prototype.toLocaleString (2.17 KB, patch)
2005-06-13 05:26 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Implementation of Object.prototype.toLocaleString (2.17 KB, patch)
2005-07-13 16:47 PDT, Geoffrey Garen
mjs: review+
Details | Formatted Diff | Diff
/fast/js/object-prototype-toLocaleString.html (903 bytes, text/html)
2005-07-13 16:48 PDT, Geoffrey Garen
no flags Details
/fast/js/object-prototype-toLocaleString.html (1009 bytes, text/html)
2005-07-14 10:04 PDT, Geoffrey Garen
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2005-06-10 07:53:00 PDT
Section 15.2.4 of ECMA-262 specification lists toString, toLocaleString, valueOf, hasOwnProperty, 
isPrototypeOf and propertyIsEnumerable.  WebKit currently only supports toString and valueOf.  Bug 
#3293 covers hasOwnProperty.
Comment 1 Mark Rowe (bdash) 2005-06-13 05:26:56 PDT
Created attachment 2293 [details]
Implementation of Object.prototype.toLocaleString
Comment 2 Geoffrey Garen 2005-07-13 16:34:32 PDT
*** Bug 3989 has been marked as a duplicate of this bug. ***
Comment 3 Geoffrey Garen 2005-07-13 16:47:54 PDT
Created attachment 2951 [details]
Implementation of Object.prototype.toLocaleString

Previous patch had merge conflicts.
Comment 4 Geoffrey Garen 2005-07-13 16:48:45 PDT
Created attachment 2952 [details]
/fast/js/object-prototype-toLocaleString.html

layout test
Comment 5 Maciej Stachowiak 2005-07-13 19:53:02 PDT
Comment on attachment 2951 [details]
Implementation of Object.prototype.toLocaleString

r=me if the testing shows this matches other browsers.
Comment 6 Geoffrey Garen 2005-07-14 10:04:17 PDT
Created attachment 2961 [details]
/fast/js/object-prototype-toLocaleString.html

better output on failure
Comment 7 Geoffrey Garen 2005-07-14 10:12:39 PDT
(In reply to comment #5)

Firefox and WinIE match. Mac IE doesn't, because it doesn't implement toLocaleString() at all. Upshot: I'll 
land the patch.
Comment 8 Geoffrey Garen 2005-07-14 10:42:26 PDT
Bug #3999 tracks propertyIsEnumerable. Bug #4000 tracks isPrototypeOf. This bug is only for 
toLocaleString(), so I'm closing it.