VERIFIED FIXED 3407
accesskey doesn't work properly with <legend> 
https://bugs.webkit.org/show_bug.cgi?id=3407
Summary accesskey doesn't work properly with <legend>
Joost de Valk (AlthA)
Reported 2005-06-10 00:18:04 PDT
Apple radar bugs: 3481830, 3481843, 3481846
Attachments
testcase (complete lay-out/accesskey test) (2.48 KB, text/html)
2005-06-10 00:59 PDT, Joost de Valk (AlthA) 		no flags
Details
Fix (6.62 KB, patch)
2005-06-11 05:24 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
A patch that actually applies (6.96 KB, patch)
2005-06-13 00:30 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joost de Valk (AlthA)
Comment 1 2005-06-10 00:59:06 PDT
Created attachment 2205 [details] testcase (complete lay-out/accesskey test) area and label seem to work, legend doesn't.
Anders Carlsson
Comment 2 2005-06-11 05:24:43 PDT
Created attachment 2246 [details] Fix Here's a patch that fixes accesskeys for legends. It also adds javascript focus methods for legends and accesskeys.
Anders Carlsson
Comment 3 2005-06-13 00:30:30 PDT
Created attachment 2292 [details] A patch that actually applies Looks like the previous patch didn't apply at all. Here's a new one that should apply
Joost de Valk (AlthA)
Comment 4 2005-06-13 00:48:58 PDT
Patch (the second one) applies cleanly, and more important, works! Kudos to andersca for that :)
Darin Adler
Comment 5 2005-06-16 09:37:31 PDT
Comment on attachment 2292 [details] A patch that actually applies Patch looks good to me for coding style, although I don't know much about how legends are supposed to work.
Anders Carlsson
Comment 6 2005-06-16 09:41:39 PDT
Focusing a legend should focus the first form element in the legend, that's what WinIE and Mozilla do.
Joost de Valk (AlthA)
Comment 7 2005-06-16 12:37:28 PDT
Yeah i agree with that. http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.11 is unclear as to what focussing a legend should do.
Darin Adler
Comment 8 2005-06-18 21:15:18 PDT
Changing the title to reflect that area and label seem to work already.
Darin Adler
Comment 9 2005-06-18 21:49:57 PDT
This patch fixes more than the bug marked here. This time I'm just going to make all the needed tests and land it, but next time I'll insist on using separate bug reports for separate fixes.
Chris Petersen
Comment 10 2005-06-18 23:09:04 PDT
Reporter, please mark this bug as Verified if this issue has been fixed in the latest TOT Webkit.
Joost de Valk (AlthA)
Comment 11 2005-06-19 23:05:34 PDT
Verified, and thx fot the hint Chris ;) Should this testcase be added to cvs btw?
Darin Adler
Comment 12 2005-06-20 08:59:36 PDT
We currently don't have a place for "manual" test cases, but when we do it would be good to put this one in there. I created an automatic test case for this particular bug and landed it along with the bug fix in the layout- tests directory.
Note You need to log in before you can comment on or make changes to this bug.