Bug 32504 – Provide Example Printing Implementation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

Extend the existing WinLauncher application with an example printing implementation.

[Brent Fulgham]

Created attachment 44775 [details]
Add an example printing implementation the WinLauncher example program.

[WebKit Review Bot]

Attachment 44775 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/WinLauncher/WinLauncher.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/WinLauncher/WinLauncher.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.h:33:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKitTools/WinLauncher/WinLauncher.h:102:  Extra space after ( in function call  [whitespace/parens] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:76:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 7

[Brent Fulgham]

Created attachment 44842 [details]
Extend WinLauncher with printing support.

[WebKit Review Bot]

Attachment 44842 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/WinLauncher/WinLauncher.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.h:33:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKitTools/WinLauncher/WinLauncher.h:102:  Extra space after ( in function call  [whitespace/parens] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:76:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 6

[Brent Fulgham]

Created attachment 44846 [details]
Revised patch to clean up check-webkit-style warnings.

[WebKit Review Bot]

Attachment 44846 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/WinLauncher/WinLauncher.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:27:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WinLauncher/PrintWebUIDelegate.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4

[Adam Roben (:aroben)]

Comment on attachment 44846 [details]
Revised patch to clean up check-webkit-style warnings.

> +HRESULT STDMETHODCALLTYPE PrintWebUIDelegate::QueryInterface(REFIID riid, void** ppvObject)

There's no need for STDMETHODCALLTYPE on any function defintions in this file. Having it on the declaration is all that matters.

> +{
> +    *ppvObject = 0;
> +    if (IsEqualGUID(riid, IID_IUnknown))
> +        *ppvObject = static_cast<IWebUIDelegate*>(this);
> +    else if (IsEqualGUID(riid, IID_IWebUIDelegate))
> +        *ppvObject = static_cast<IWebUIDelegate*>(this);

IsEqualIID would be a little better.

> +ULONG STDMETHODCALLTYPE PrintWebUIDelegate::Release(void)
> +{
> +    ULONG newRef = --m_refCount;
> +    if (!newRef)
> +        delete(this);

No need for the parentheses around "this".

> +    IWebFramePrivate* privateFrame = 0;
> +    if (FAILED(mainFrame->QueryInterface(IID_IWebFramePrivate, (void**)&privateFrame))) {
> +        mainFrame->Release();
> +        return E_FAIL;
> +    }

You should be able to use the single-parameter version of QueryInterface here, which also removes the need for the cast. You can also unconditionally release mainFrame right after calling QueryInterface:

IWebFramePrivate* privateFrame = 0;
HRESULT hr = mainFrame->QueryInterface(&privateFrame);
mainFrame->Release();
if (FAILED(hr))
    return E_FAIL;

> +    rect->left += 20;
> +    rect->top += 20;
> +    rect->right -= 20; 
> +    rect->bottom -= 20;

Can we put this 20 in a constant?

> +    gPrintDelegate = new PrintWebUIDelegate();

No need for parentheses here.

> +BOOL CALLBACK AbortProc(HDC hDC, int Error)

Can this be marked static?

> +{
> +    MSG msg;
> +    while (::PeekMessage(&msg, 0, 0, 0, PM_REMOVE)) {

Why not use GetMessage? Do you need to check for a -1 return value?

> +    IWebFramePrivate* framePrivate = 0;
> +    if (FAILED (frame->QueryInterface(&framePrivate)))
> +        goto exit;

Extra space after FAILED. You can release frame uncoditionally after calling QueryInterface. Then you won't need the goto.

> +    void* graphicsContext = 0;
> +    for (size_t page = 0; page < pageCount; ++page) {
> +        ::StartPage(printDC);
> +        framePrivate->spoolPages(printDC, page, page, graphicsContext);
> +        ::EndPage(printDC);
> +    }

This won't work in CG builds. It would be nice to detect that we're in a CG build and show a message to the user.

r=me

[Brent Fulgham]

Landed in http://trac.webkit.org/changeset/52400.