Bug 28022 - [Chromium] Some minor fixes needed to turn on asserts in Skia
Summary: [Chromium] Some minor fixes needed to turn on asserts in Skia
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-05 11:02 PDT by Stephen White
Modified: 2009-08-05 19:39 PDT (History)
1 user (show)

See Also:

Attachments
Check args before calling skia's drawRoundRect to prevent assert (1.39 KB, patch)
2009-08-05 11:08 PDT, Stephen White 		dglazkov: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2009-08-05 11:02:26 PDT 
Skia doesn't like 0-width rounded rects (it will assert).
Comment 1 Stephen White 2009-08-05 11:08:21 PDT 
Created attachment 34152 [details]
Check args before calling skia's drawRoundRect to prevent assert
Comment 2 Dimitri Glazkov (Google) 2009-08-05 16:02:51 PDT 
Comment on attachment 34152 [details]
Check args before calling skia's drawRoundRect to prevent assert

Great!
Comment 3 Adam Barth 2009-08-05 19:39:28 PDT 
Comment on attachment 34152 [details]
Check args before calling skia's drawRoundRect to prevent assert

Clearing review flag on attachment: 34152

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderThemeChromiumSkia.cpp
Committed r46826
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderThemeChromiumSkia.cpp
r46826 = 21857865ac6b339cec28d9ff0cceae543db906b3 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46826
Comment 4 Adam Barth 2009-08-05 19:39:32 PDT 
All reviewed patches have been landed.  Closing bug.