Several classes which inherited from Noncopyable are instantiated by operator new, so we need to inherit Noncopyable from FastAllocBase. Since the new/delete operators customizing is public we need to change some private Noncopyable inheritance to public.
Created attachment 33875 [details] proposed patch
Comment on attachment 33875 [details] proposed patch This is a big one, that will affect tons of classes. Lets make sure this gets tested well. r=me
I have concerns, based on 3 failures shown in other bugs, that Zoltan is not running the layout tests before posting these patches. I will run them when attempting to land this one, but it would make things easier if they were run beforehand.
tables/mozilla/bugs/bug2479-4.html -> failed I'm not sure why yet. It doesn't seem to be faiilng on the bots.
Oliver: Here's the another patch similar to the one you didn't like. Would you like to double check it?
Comment on attachment 33875 [details] proposed patch Olliej said this was fine on IRC.
Comment on attachment 33875 [details] proposed patch A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following files contain tab characters: trunk/WebCore/ChangeLog Please use spaces instead to indent.
Created attachment 34232 [details] updated proposed patch I didn't see the tabs in my previous patch. Anyway, I've filed this new one.
Comment on attachment 34232 [details] updated proposed patch Thanks!
Comment on attachment 34232 [details] updated proposed patch Clearing review flag on attachment: 34232 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Noncopyable.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp M WebKit/win/COMPropertyBag.h M WebKit/win/ChangeLog Committed r46877 M JavaScriptCore/wtf/Noncopyable.h M JavaScriptCore/ChangeLog M WebKit/win/ChangeLog M WebKit/win/COMPropertyBag.h M WebCore/ChangeLog M WebCore/platform/graphics/wince/GraphicsContextWince.cpp r46877 = 5cd67bb8bf95afdfedae7a0d1f5568cc7b9ef674 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46877
All reviewed patches have been landed. Closing bug.
Reverted in http://trac.webkit.org/changeset/46880 because this broke the GTK build.
I separated this patch into 2 parts. This bug will only contains the Noncopyable's inheritance from FastAllocBase, and the other will change the classes inheriting to publicly: bug #28065
I filed a new patch which repairs the GTK+'s build as well: bug #28066.
Created attachment 34268 [details] updated patch for Noncopyable This is the change only for Noncopyable. The modify may need a clean build!
Comment on attachment 34268 [details] updated patch for Noncopyable OK. You've run the tests I assume?
Comment on attachment 34268 [details] updated patch for Noncopyable Clearing review flag on attachment: 34268 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Noncopyable.h Committed r46933 M LayoutTests/platform/gtk/Skipped M LayoutTests/ChangeLog r46932 = da3a69d32fd865d387199ab82c7fc500a13250dd (trunk) M JavaScriptCore/wtf/Noncopyable.h M JavaScriptCore/ChangeLog r46933 = e1ea42d97298edc474892c9abbd9a445448e6359 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46933