Bug 27879 - Allow custom memory allocation control for JavaScriptCore's Noncopyable class
Summary: Allow custom memory allocation control for JavaScriptCore's Noncopyable class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 28065 28066
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-31 07:10 PDT by Zoltan Horvath
Modified: 2009-08-07 17:41 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (4.03 KB, patch)
2009-07-31 07:16 PDT, Zoltan Horvath
abarth: review-
abarth: commit-queue-
Details | Formatted Diff | Diff
updated proposed patch (4.00 KB, patch)
2009-08-06 15:39 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
updated patch for Noncopyable (1.14 KB, patch)
2009-08-07 05:13 PDT, Zoltan Horvath
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-31 07:10:46 PDT
Several classes which inherited from Noncopyable are instantiated by operator new, so we need to inherit Noncopyable from FastAllocBase. Since the new/delete operators customizing is public we need to change some private Noncopyable inheritance to public.
Comment 1 Zoltan Horvath 2009-07-31 07:16:39 PDT
Created attachment 33875 [details]
proposed patch
Comment 2 Darin Adler 2009-07-31 13:48:16 PDT
Comment on attachment 33875 [details]
proposed patch

This is a big one, that will affect tons of classes. Lets make sure this gets tested well.

r=me
Comment 3 Eric Seidel (no email) 2009-07-31 17:10:16 PDT
I have concerns, based on 3 failures shown in other bugs, that Zoltan is not running the layout tests before posting these patches.  I will run them when attempting to land this one, but it would make things easier if they were run beforehand.
Comment 4 Eric Seidel (no email) 2009-07-31 20:53:11 PDT
tables/mozilla/bugs/bug2479-4.html -> failed

I'm not sure why yet.  It doesn't seem to be faiilng on the bots.
Comment 5 Adam Barth 2009-08-01 21:40:27 PDT
Oliver: Here's the another patch similar to the one you didn't like.  Would you like to double check it?
Comment 6 Adam Barth 2009-08-05 23:26:54 PDT
Comment on attachment 33875 [details]
proposed patch

Olliej said this was fine on IRC.
Comment 7 Adam Barth 2009-08-06 12:58:07 PDT
Comment on attachment 33875 [details]
proposed patch

A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following files contain tab characters:

        trunk/WebCore/ChangeLog

    Please use spaces instead to indent.
Comment 8 Zoltan Horvath 2009-08-06 15:39:19 PDT
Created attachment 34232 [details]
updated proposed patch

I didn't see the tabs in my previous patch. Anyway, I've filed this new one.
Comment 9 Adam Barth 2009-08-06 15:44:24 PDT
Comment on attachment 34232 [details]
updated proposed patch

Thanks!
Comment 10 Adam Barth 2009-08-06 18:09:21 PDT
Comment on attachment 34232 [details]
updated proposed patch

Clearing review flag on attachment: 34232

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Noncopyable.h
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/wince/GraphicsContextWince.cpp
	M	WebKit/win/COMPropertyBag.h
	M	WebKit/win/ChangeLog
Committed r46877
	M	JavaScriptCore/wtf/Noncopyable.h
	M	JavaScriptCore/ChangeLog
	M	WebKit/win/ChangeLog
	M	WebKit/win/COMPropertyBag.h
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/wince/GraphicsContextWince.cpp
r46877 = 5cd67bb8bf95afdfedae7a0d1f5568cc7b9ef674 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46877
Comment 11 Adam Barth 2009-08-06 18:09:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 Adam Barth 2009-08-06 22:40:46 PDT
Reverted in http://trac.webkit.org/changeset/46880 because this broke the GTK build.
Comment 13 Zoltan Horvath 2009-08-07 01:49:04 PDT
I separated this patch into 2 parts. 

This bug will only contains the Noncopyable's inheritance from FastAllocBase, and the other will change the classes inheriting to publicly: bug #28065
Comment 14 Zoltan Horvath 2009-08-07 04:55:47 PDT
I filed a new patch which repairs the GTK+'s build as well: bug #28066.
Comment 15 Zoltan Horvath 2009-08-07 05:13:44 PDT
Created attachment 34268 [details]
updated patch for Noncopyable

This is the change only for Noncopyable. The modify may need a clean build!
Comment 16 Eric Seidel (no email) 2009-08-07 14:03:52 PDT
Comment on attachment 34268 [details]
updated patch for Noncopyable

OK.  You've run the tests I assume?
Comment 17 Adam Barth 2009-08-07 17:41:37 PDT
Comment on attachment 34268 [details]
updated patch for Noncopyable

Clearing review flag on attachment: 34268

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/Noncopyable.h
Committed r46933
	M	LayoutTests/platform/gtk/Skipped
	M	LayoutTests/ChangeLog
r46932 = da3a69d32fd865d387199ab82c7fc500a13250dd (trunk)
	M	JavaScriptCore/wtf/Noncopyable.h
	M	JavaScriptCore/ChangeLog
r46933 = e1ea42d97298edc474892c9abbd9a445448e6359 (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46933
Comment 18 Adam Barth 2009-08-07 17:41:43 PDT
All reviewed patches have been landed.  Closing bug.