Bug 27871 - [commit+] Allow custom memory allocation control for JavaScriptCore's HashMap class
Summary: [commit+] Allow custom memory allocation control for JavaScriptCore's HashMap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 02:21 PDT by Zoltan Horvath
Modified: 2009-08-01 11:36 PDT (History)
2 users (show)

See Also:


Attachments
proposed patch (1.32 KB, patch)
2009-07-31 02:24 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-31 02:21:35 PDT
Inherits HashMap class from FastAllocBase because it has been instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.
Comment 1 Zoltan Horvath 2009-07-31 02:24:35 PDT
Created attachment 33864 [details]
proposed patch
Comment 2 Darin Adler 2009-07-31 09:29:41 PDT
Comment on attachment 33864 [details]
proposed patch

> +        * wtf/RefPtrHashMap.h:
> +        (WTF::):

Please don't leave broken lines like this in the change log just because the prepare-ChangeLog script put them there.
Comment 3 Eric Seidel (no email) 2009-07-31 22:02:14 PDT
I had this failure again:
tables/mozilla/bugs/bug2479-4.html -> failed

Starting to think it might not be related to these patches.
Comment 4 Adam Barth 2009-08-01 11:35:59 PDT
Comment on attachment 33864 [details]
proposed patch

Clearing review flag on attachment: 33864

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/RefPtrHashMap.h
Committed r46675
	A	LayoutTests/platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt
	M	LayoutTests/platform/win/Skipped
	M	LayoutTests/ChangeLog
r46674 = d76ae4ee615ab1d3fa82d062c8ef4299bd89bd76 (trunk)
	M	JavaScriptCore/wtf/RefPtrHashMap.h
	M	JavaScriptCore/ChangeLog
r46675 = a3b8eb2865ca4b26d3b75bc0f0e72e669b2e99ce (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46675
Comment 5 Adam Barth 2009-08-01 11:36:03 PDT
All reviewed patches have been landed.  Closing bug.