RESOLVED FIXED27388
[Chromium] CSS dotted/dashed borders in Chromium/skia are generally hosed 
https://bugs.webkit.org/show_bug.cgi?id=27388
Summary [Chromium] CSS dotted/dashed borders in Chromium/skia are generally hosed
Stephen White
Reported 2009-07-17 14:21:33 PDT
Dotted and dashed 1px borders in Chromium/skia draw weird antialiased grey lines instead of distinct dots. See: http://crbug.com/474
Attachments
Fix for 1px CSS border issue (5.86 KB, patch)
2009-07-17 14:25 PDT, Stephen White 		eric: review+
DetailsFormatted DiffDiff
Revert of previous patch. (5.77 KB, patch)
2009-07-24 08:09 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Re-apply (unrevert) the patch. (5.82 KB, patch)
2009-07-27 07:09 PDT, Stephen White 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2009-07-17 14:25:33 PDT
Created attachment 32970 [details] Fix for 1px CSS border issue
Eric Seidel (no email)
Comment 2 2009-07-20 15:13:57 PDT
Comment on attachment 32970 [details] Fix for 1px CSS border issue Not much for me to say here. As long as this passes tests, it looks sane. Sad that we can't share more of this code.
David Levin
Comment 3 2009-07-21 02:56:14 PDT
Committed as http://trac.webkit.org/changeset/46157
Stephen White
Comment 4 2009-07-24 08:05:56 PDT
This fix may be causing reliability problems in Chromium. Reverting.
Stephen White
Comment 5 2009-07-24 08:09:23 PDT
Created attachment 33448 [details] Revert of previous patch.
David Levin
Comment 6 2009-07-24 09:05:32 PDT
Comment on attachment 33448 [details] Revert of previous patch. Verified that it is simply a revert and (essentially) rubberstamping.
Darin Fisher (:fishd, Google)
Comment 7 2009-07-24 10:44:41 PDT
Landed as: http://trac.webkit.org/changeset/46363
Stephen White
Comment 8 2009-07-27 06:49:56 PDT
Reopening this bug, since the fix was reverted.
Stephen White
Comment 9 2009-07-27 07:09:50 PDT
Created attachment 33544 [details] Re-apply (unrevert) the patch.
David Levin
Comment 10 2009-07-27 08:13:53 PDT
Comment on attachment 33448 [details] Revert of previous patch. Clearing the r+ since this patch was applied (and the bug has ben re-opened).
David Levin
Comment 11 2009-07-27 08:16:13 PDT
Comment on attachment 33544 [details] Re-apply (unrevert) the patch. Really reviewed by Eric really. I verified that this is the same patch that Eric r+ before.
David Levin
Comment 12 2009-07-27 17:51:09 PDT
Committed (again) as http://trac.webkit.org/changeset/46447
Note You need to log in before you can comment on or make changes to this bug.