Bug 26070 - [Qt] EventSender.keyDown doesn't support Arrow Up and Down keys.
Summary: [Qt] EventSender.keyDown doesn't support Arrow Up and Down keys.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Adam Barth
URL:
Keywords: Qt
Depends on:
Blocks: 20303
  Show dependency tree / graph
 
Reported: 2009-05-28 14:54 PDT by Yongjun Zhang
Modified: 2009-06-02 00:01 PDT (History)
2 users (show)

See Also:

Attachments
add support for Up Key and Down Key handling. (1.62 KB, patch)
2009-05-28 14:58 PDT, Yongjun Zhang 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-05-28 14:54:11 PDT 
It supports Left & Right key, but not Up and Down key.
Comment 1 Yongjun Zhang 2009-05-28 14:58:00 PDT 
Created attachment 30754 [details]
add support for Up Key and Down Key handling.
Comment 2 Holger Freyther 2009-05-28 18:57:37 PDT 
Okay, it looks good but for which unit test are you doing this? Why isn't the Skipped list updated after having fixed this issue?
Comment 3 Yongjun Zhang 2009-05-29 08:07:22 PDT 
Hi, there is no existing layout testcase for this fix (at least I couldn't find one in Skipped list). I spot this bug when I was trying to create a layout test for https://bugs.webkit.org/show_bug.cgi?id=20303. 

How about I create a layout test case under LayoutTest/platform/qt/events to test this fix?
Comment 4 Holger Freyther 2009-05-29 18:17:06 PDT 
Comment on attachment 30754 [details]
add support for Up Key and Down Key handling.

Okay, the last comment was quite nice. Please land together with the fix in bug #20303 so we can sure to not touch this part of the code.
Comment 5 Adam Barth 2009-06-01 23:55:00 PDT 
Will land.
Comment 6 Adam Barth 2009-06-02 00:01:07 PDT 
Sending        WebKitTools/ChangeLog
Sending        WebKitTools/DumpRenderTree/qt/jsobjects.cpp
Transmitting file data ..
Committed revision 44349.