Bug 23425 - Clean up setShouldAntialias/setUseAntialiasing on GraphicsContext
Summary: Clean up setShouldAntialias/setUseAntialiasing on GraphicsContext
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-19 16:58 PST by Simon Fraser (smfr)
Modified: 2009-01-20 13:01 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-01-19 16:58:52 PST 
The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, GraphicsContexet already has:

        void setShouldAntialias(bool);
        bool shouldAntialias() const;

so now we have 2 antialiasing methods. This needs cleaning up.
Comment 1 Rob Buis 2009-01-19 23:40:13 PST 
Hi Simon,

(In reply to comment #0)
> The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However,
> GraphicsContexet already has:
> 
>         void setShouldAntialias(bool);
>         bool shouldAntialias() const;
> 
> so now we have 2 antialiasing methods. This needs cleaning up.

Ok, I'll have a look tonight.
Cheers,

Rob.
Comment 2 Rob Buis 2009-01-20 12:55:36 PST 
Hi Simon,

(In reply to comment #0)
> The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However,
> GraphicsContexet already has:
> 
>         void setShouldAntialias(bool);
>         bool shouldAntialias() const;
> 
> so now we have 2 antialiasing methods. This needs cleaning up.

Now that I looked at it, setUseAntialiasing is gone! It was removed in the same patch that added  setShouldAntialias .Also the shape-rendering.svg test still works fine, so I think this report can be closed.
Cheers,

Rob.

PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am not sure in what context that is important?
Comment 3 Darin Adler 2009-01-20 12:59:44 PST 
(In reply to comment #2)
> PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am
> not sure in what context that is important?

That’s a file used to optimize performance on Mac OS X that has to be regenerated from time to time by actually testing some usage scenarios. It’s quite out of date at the moment. There’s no harm in having it mention a function that doesn’t exist.
Comment 4 Simon Fraser (smfr) 2009-01-20 13:01:29 PST 
OK, sorry about filing this. I was confused by a conflict I had with some local changes. I think we're all good.