Bug 22553 – Remove unneeded GObject casts.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

g_object_get, g_object_set, g_signal_connect, etc. all take a gpointer argument, so there is no need to cast to GObject with the G_OBJECT macro.

[Xan Lopez]

Created attachment 25594 [details]
Remove unneeded GObject casts.

[Holger Freyther]

Comment on attachment 25594 [details]
Remove unneeded GObject casts.

> From 986ed09d38f02e5a51fd5b9834cafe06e7e272e1 Mon Sep 17 00:00:00 2001
> From: Xan Lopez <[e-mail]>
> Date: Sat, 29 Nov 2008 14:09:59 +0200
> Subject: [PATCH] Remove unneeded GObject casts.
> 
> ---
>  WebKit/gtk/ChangeLog                             |   28 ++++++++++++++++++++++
>  WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp    |   22 ++++++++--------
>  WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp |    4 +-
>  WebKit/gtk/webkit/webkitwebframe.cpp             |    6 ++--
>  WebKit/gtk/webkit/webkitwebview.cpp              |    4 +-
>  WebKit/gtk/webkit/webkitwebwindowfeatures.cpp    |   10 ++++----
>  6 files changed, 51 insertions(+), 23 deletions(-)
> 
> diff --git a/WebKit/gtk/ChangeLog b/WebKit/gtk/ChangeLog
> index 57a6479..62e35b6 100644
> --- a/WebKit/gtk/ChangeLog
> +++ b/WebKit/gtk/ChangeLog
> @@ -1,3 +1,31 @@
> [phone]  Xan Lopez  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=22553

indention wrong? mixing tabs and spaces?

besides that, you are right, g_object_set, g_object_ref, g_object_unref take a plain gpointer and there is no need to cast it.

[Christian Dywan]

2008-12-01  Xan Lopez  <[e-mail]>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=22553
        Remove unneeded GObject casts.

        Remove unneeded casts to GObject in functions that take a gpointer
        argument.