Bug 21491 - LayoutTests/transitions/opacity-transition-zindex.html is timing sensitive
Summary: LayoutTests/transitions/opacity-transition-zindex.html is timing sensitive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-08 17:49 PDT by Tony Chang
Modified: 2009-01-03 16:59 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-10-08 17:49:40 PDT
LayoutTests/transitions/opacity-transition-zindex.html runs a CSS animation with a duration of 5 seconds.  The test finishes (calls layoutTestController.notifyDone()) after 2.5 seconds.  This makes it impossible for there to be a pixel result for the test since dumping the pixel results happens during the middle of the transition.  On Chromium, we run pixel tests with every run, so it's not possible for us to pass this test.

Would the test still be valid if we changed it to use layoutTestController.dumpAsText()?  We could get the z-indexes with some javascript.

Also, 2.5s for a single layout test seems way too long.
Comment 1 Simon Fraser (smfr) 2008-10-08 18:05:34 PDT
I would like to see the render tree for this test. Maybe we should just make everything visibility:hidden at the end?
Comment 2 Tony Chang 2008-10-09 13:06:51 PDT
Changing what happens at the end of the test (after 5s) doesn't help.

To clarify, the problem with dumping the pixel results during the middle of the css transition is that the exact image that gets dumped varies depending on the speed of the computer.  It doesn't seem like it's possible to dump the render tree and not grab a pixel dump (or have them dumped at different times).
Comment 3 Simon Fraser (smfr) 2008-10-09 13:14:33 PDT
Yeah, what we really need is a test-only API to freeze transitions.

Another "solution" here would be to give rgba(, , , 0) colors to everything. Suck.
Comment 4 Simon Fraser (smfr) 2009-01-03 16:59:19 PST
Test now uses the 'pauseTransitionAtTimeOnElementWithId' API.