Bug 20582 – [Gtk] Link error on Mac OS X

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[MrGwen]

I've this link error under MacOs when I try to build WebKit-GTK+

ld: unknown option: --version-script
collect2: ld returned 1 exit status


Solution from bdash from IRC :

remove line 253 of GNUmakefile.am and rebuild
someone went and made the makefile dependent on the GNU linker

[MrGwen]

*** Bug 20581 has been marked as a duplicate of this bug. ***

[Mike Hommey]

Created attachment 23405 [details]
patch

Not tested, because I lack time to test right now, but this should work

[Mike Hommey]

Note that we might want to invert the filtering, instead, and export all webkit_* and (to be defined) symbols, and use the libtool -export-symbols option that would also probably work on osx.

[Alp Toker]

(In reply to comment #3)
> Note that we might want to invert the filtering, instead, and export all
> webkit_* and (to be defined) symbols, and use the libtool -export-symbols
> option that would also probably work on osx.
> 

Do you want to have a go and see if that works or should we just get your fix in?

If you do try that, remember to check the exported symbols to make sure it doesn't drop anything we make public at the moment.

[Mike Hommey]

I'd go for it if I knew all the exported symbols patterns ;)

[Darin Adler]

Comment on attachment 23405 [details]
patch

Looks good. Even though I'm not an expert on the GTK port, I'm comfortable saying r=me.

But needs a ChangeLog. I'm going to say review- because it's not fair to expect the committer to write the ChangeLog.

[Richard Hult]

The GNUmakefile.am part is not right, you can't have conditionals in the middle of LDFLAGS like that, it will not produce a correct makefile. I'll attach a correct version.

[Richard Hult]

Created attachment 23648 [details]
Correct way to have conditional flags

I also made a change to the configure.ac part, setting the os_gnu variable to no in the other case, to make it consistent with the other similar variables.

[Jan Alonzo]

Hi Richard

Can you make your patch's flag '?' so it will go to the review queue? And kindly add a Changelog entry. Thanks.

[Richard Hult]

Created attachment 23703 [details]
New version with changelog entry

[Alp Toker]

Comment on attachment 23703 [details]
New version with changelog entry

r=me

[Jan Alonzo]

landed in r36845

[Mike Hommey]

+version_script = Wl,--version-script,$(srcdir)/symbols.filter

The dash is missing before Wl, so this doesn't have any effect (I'm even surprised it doesn't break the build)

[Jan Alonzo]

Thanks Mike! Fixed in r37887.