Bug 20338 - [Gtk] Autotools should check for libxslt
Summary: [Gtk] Autotools should check for libxslt
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-08-08 18:28 PDT by Jan Alonzo
Modified: 2008-08-09 20:30 PDT (History)
1 user (show)

See Also:


Attachments
check for libxslt in autotools (848 bytes, patch)
2008-08-08 18:29 PDT, Jan Alonzo
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-08-08 18:28:55 PDT
We're not checking for libxslt and hence, missing -lxslt in the build.
Comment 1 Jan Alonzo 2008-08-08 18:29:24 PDT
Created attachment 22716 [details]
check for libxslt in autotools
Comment 2 Mark Rowe (bdash) 2008-08-09 18:35:22 PDT
Comment on attachment 22716 [details]
check for libxslt in autotools

r=me
Comment 3 Jan Alonzo 2008-08-09 19:04:01 PDT
Thanks. landed in r35654
Comment 4 Alp Toker 2008-08-09 19:52:33 PDT
Hi,

The patch was missing a $ and broke the build:

+                  libxslt >= LIBXSLT_REQUIRED_VERSION

Moreover, we do check for libxslt, but only if XSL support is enabled in configure:

# check if libxslt is available
if test "$enable_xslt" = "yes"; then
   PKG_CHECK_MODULES([LIBXSLT],[libxslt >= $LIBXSLT_REQUIRED_VERSION])
   AC_SUBST([LIBXSLT_CFLAGS])
   AC_SUBST([LIBXSLT_LIBS])
fi

Jan, was the existing XSLT check broken for you?
Comment 5 Alp Toker 2008-08-09 20:02:05 PDT
(In reply to comment #3)
> Thanks. landed in r35654
> 

Backed out in r35655 to get things building. Jan, can you describe the configure issue so we can try again if there's still an issue?

Cheers
Comment 6 Jan Alonzo 2008-08-09 20:30:56 PDT
Hi Alp

Thanks for the rollback. This issue doesn't seem to be a WebKit/Gtk issue, but rather a packaged webkitgtk issue. Closing as INVALID as we don't really have to do anything here.

FYI, I think you need to update the changelog which revision was actually rolled back. Here's your commit message:


    GTK+ build fixes.

    Back out r20338 libxslt check (conditional check already exists and
    this broke the build).

    Make the flex version check a warning rather than fatal to fix the
    build bot. 

Cheers