In setSharedTimerFireTime: if (intervalInMS == 0) - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, NULL); + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, NULL, NULL); I'm attaching a patch for this.
Created attachment 22697 [details] use G_PRIORITY_DEFAULT_IDLE for g_idle_add function
(In reply to comment #0) > In setSharedTimerFireTime: > > if (intervalInMS == 0) > - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, > NULL); > + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, > NULL, NULL); > > I'm attaching a patch for this. > Did this cause incorrect behaviour or is this patch just a cleanup? How about just using g_idle_add() (docs suggest it does the same thing)?
Created attachment 22715 [details] updated to use g_idle_add rather than the _full variant Hi Alp This is just a cleanup. I've updated the patch to use g_idle_add rather than g_idle_add_full.
Comment on attachment 22715 [details] updated to use g_idle_add rather than the _full variant Please adjust the changelog when landing. According to the glib documentation g_idle_add is there from the beginning so we can safely use that.
landed in r35724