Bug 19429 - Refactor ContextMenu into Platform implementations
Summary: Refactor ContextMenu into Platform implementations
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-07 11:34 PDT by Christian Dywan
Modified: 2008-06-07 11:34 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Dywan 2008-06-07 11:34:15 PDT
Following up bug 17324 as suggested by Adam.

> It seems to me that a better approach would be to move the menu
> items into ContextMenu{Gtk,Mac,Win,Wx,Qt}.cpp, instead of moving
> the logic up into WebKit. WebKit's for the most part supposed to
> be a thin API layer that wraps WebCore, so I don't think moving
> this kind of logic there is the right direction to go in.

The ContextMenu should be refactored into platform specific implementations while many items still should be shared among ports.