WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
19429
Refactor ContextMenu into Platform implementations
https://bugs.webkit.org/show_bug.cgi?id=19429
Summary
Refactor ContextMenu into Platform implementations
Christian Dywan
Reported
2008-06-07 11:34:15 PDT
Following up
bug 17324
as suggested by Adam.
> It seems to me that a better approach would be to move the menu > items into ContextMenu{Gtk,Mac,Win,Wx,Qt}.cpp, instead of moving > the logic up into WebKit. WebKit's for the most part supposed to > be a thin API layer that wraps WebCore, so I don't think moving > this kind of logic there is the right direction to go in.
The ContextMenu should be refactored into platform specific implementations while many items still should be shared among ports.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug