REGRESSION(r34273): ASSERTION FAILED: startingLineNumber > 0 with PAC file

[Eric Seidel (no email)]

TOT WebKit hits ASSERT loading Google's internal homepage. :(

ASSERTION FAILED: startingLineNumber > 0
(/Users/eseidel/Projects/WebKit/JavaScriptCore/kjs/Parser.cpp:70 void KJS::Parser::parse(KJS::ExecState*, const KJS::UString&, int, WTF::PassRefPtr<KJS::SourceProvider>, int*, int*, KJS::UString*))

I can see if I can create a reduction for you.

[Eric Seidel (no email)]

Actually, looks like it's due to Google's PAC file:

Thread 3 Crashed:
0   com.apple.JavaScriptCore      	0x004a1b2b KJS::Parser::parse(KJS::ExecState*, KJS::UString const&, int, WTF::PassRefPtr<KJS::SourceProvider>, int*, int*, KJS::UString*) + 243 (Parser.cpp:70)
1   com.apple.JavaScriptCore      	0x004e9a89 WTF::PassRefPtr<KJS::ProgramNode> KJS::Parser::parse<KJS::ProgramNode>(KJS::ExecState*, KJS::UString const&, int, WTF::PassRefPtr<KJS::SourceProvider>, int*, int*, KJS::UString*) + 103 (Parser.h:88)
2   com.apple.JavaScriptCore      	0x004a1f9e KJS::Interpreter::checkSyntax(KJS::ExecState*, KJS::UString const&, int, WTF::PassRefPtr<KJS::SourceProvider>) + 118 (interpreter.cpp:52)
3   com.apple.JavaScriptCore      	0x004a20cd KJS::Interpreter::checkSyntax(KJS::ExecState*, KJS::UString const&, int, KJS::UString const&) + 79 (interpreter.cpp:42)
4   com.apple.JavaScriptCore      	0x004ea77d JSCheckScriptSyntax + 221 (JSBase.cpp:72)
5   com.apple.CFNetwork           	0x94b2d2e9 JSCheckScriptSyntax + 202
6   com.apple.CFNetwork           	0x94b16959 _createJSRuntime + 150
7   com.apple.CFNetwork           	0x94b18548 _JSSetEnvironmentForPAC + 129
8   com.apple.CFNetwork           	0x94b18857 _JSFindProxyForURL + 324
9   com.apple.CFNetwork           	0x94ada881 _CFNetworkProxyListForURLAsync + 788
10  com.apple.CFNetwork           	0x94ae7fb1 httpProtocolStart + 608
11  com.apple.CFNetwork           	0x94ad7ea0 CFURLProtocolStartLoad + 28
12  com.apple.CFNetwork           	0x94ad7cb2 _CFURLConnectionProcessServerEvents + 664
13  com.apple.CFNetwork           	0x94ad60d9 muxerSourcePerform + 283
14  com.apple.CoreFoundation      	0x903bd62e CFRunLoopRunSpecific + 3166
15  com.apple.CoreFoundation      	0x903bdd18 CFRunLoopRunInMode + 88
16  com.apple.Foundation          	0x950faac0 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] + 320
17  com.apple.Foundation          	0x950975ad -[NSThread main] + 45
18  com.apple.Foundation          	0x95097154 __NSThread__main__ + 308
19  libSystem.B.dylib             	0x94e0cc55 _pthread_start + 321
20  libSystem.B.dylib             	0x94e0cb12 thread_start + 34

[Timothy Hatcher]

I think we might want to still allow callers of JSCheckScriptSyntax and JSEvaluateScript to pass whatever starting line number they want. And only have the ASSERT for our internal uses.

[Eric Seidel (no email)]

I've commented out the ASSERT locally so I can actually use Debug WebKit.  It's impossible to use Debug WebKit for anyone who has a PAC file atm. 

[Eric Seidel (no email)]

Removed the ASSERT in:
http://trac.webkit.org/changeset/34628

I guess we can keep this bug around for adding back a proper working ASSERT.

[Gavin Barraclough]

This assert no longer exists.  If you are still seeing a problem using PAC files, please feel free to reopen with a new backtrace.