Bug 19380 - svn.facebook.com XML page is blank
Summary: svn.facebook.com XML page is blank
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Evangelism (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL: http://svn.facebook.com/svnroot/platf...
Keywords: InRadar, NeedsReduction
Depends on:
Blocks:
 
Reported: 2008-06-03 13:41 PDT by Anantha Keesara
Modified: 2008-07-17 02:27 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anantha Keesara 2008-06-03 13:41:40 PDT
http://svn.facebook.com/svnroot/platform/fbopen/

This XML page does not render at all. Firefox 2 is fine.

Here's the source:
<?xml version="1.0"?>
<?xml-stylesheet type="text/xsl" href="/skin/view/repos.xsl"?>
<!DOCTYPE svn [
 <!ELEMENT svn   (index)>
 <!ATTLIST svn   version CDATA #REQUIRED
                 href    CDATA #REQUIRED>
 <!ELEMENT index (updir?, (file | dir)*)>
 <!ATTLIST index name    CDATA #IMPLIED
                 path    CDATA #IMPLIED
                 rev     CDATA #IMPLIED>
 <!ELEMENT updir EMPTY>
 <!ELEMENT file  (prop)*>
 <!ATTLIST file  name    CDATA #REQUIRED
                 href    CDATA #REQUIRED>
 <!ELEMENT dir   (prop)*>

 <!ATTLIST dir   name    CDATA #REQUIRED
                 href    CDATA #REQUIRED>
 <!ELEMENT prop  (#PCDATA)>
 <!ATTLIST prop  name    CDATA #REQUIRED>
]>
<svn version="1.1.4 (r13838)"
    href="http://subversion.tigris.org/">
 <index rev="1176" path="/platform/fbopen">
   <updir />
   <file name="LICENSE" href="LICENSE"></file>
   <file name="README" href="README"></file>
   <dir name="fbopen-libfbml" href="fbopen-libfbml/"></dir>

   <file name="fbopen_data_dump" href="fbopen_data_dump"></file>
   <dir name="html" href="html/"></dir>
   <dir name="lib" href="lib/"></dir>
 </index>
</svn>

Other browsers behavior:
This only work in firefox, and fails in:
* Safari 3.1
* Opera
* Internet Explorer 0.7

Likely an issue with the XSL Transformation.
Comment 1 Mark Rowe (bdash) 2008-06-03 14:00:28 PDT
That's very curious.  WebKit's SVN repository at <http://svn.webkit.org/repository/webkit/> has a very similar page, which WebKit displays without problem.  There are some differences in the markup used: WebKit's appears to be from SVN 1.4.5 while Facebook is using the rather dated SVN 1.1.4.  I wonder if there isn't a bug in the XML or XSL that they have fixed in more recent versions of SVN?
Comment 2 Mark Rowe (bdash) 2008-06-03 14:08:34 PDT
<rdar://problem/5983114>
Comment 3 Alexey Proskuryakov 2008-06-04 09:16:52 PDT
There is  stray '#' symbol on line 37 of http://svn.facebook.com/skin/view/repos.xsl, which makes it fail to compile.
Comment 4 Mark Rowe (bdash) 2008-06-04 10:45:41 PDT
Alexey, any ideas why this would work in Firefox?  Given that IE and Opera also fail to display this, should we close as INVALID or move to evangelism rather than tracking this as our bug?
Comment 5 Alexey Proskuryakov 2008-06-04 23:42:05 PDT
(In reply to comment #4)
> Alexey, any ideas why this would work in Firefox?

No, not really.

I couldn't find where the specification explicitly forbids text nodes as children of xsl:template, but the intention appears obvious given that it lists all possible element nodes, and there is no use for such text nodes anyway. 

> Given that IE and Opera also fail to display this, should
> we close as INVALID or move to evangelism rather
> than tracking this as our bug?

I think so. We are supposed to be strict when dealing with XML.
Comment 6 Eric Seidel (no email) 2008-06-05 07:06:43 PDT
Evangelism would include filing a bug against Moz to have them be stricter here.
Comment 7 Robert Blaut 2008-07-17 02:27:21 PDT
As I tested today the reported site opens fine now. Tested in WebKit r35203. Closing as fixed.