Bug 19374 - Expose boundingBox value in QWebHitTestResult
Summary: Expose boundingBox value in QWebHitTestResult
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Minor
Assignee: Siraj razick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-03 07:39 PDT by Siraj razick
Modified: 2008-10-22 12:58 PDT (History)
2 users (show)

See Also:


Attachments
Expose boundingBox value in QWebHitTestResult (2.27 KB, patch)
2008-06-03 08:19 PDT, Siraj razick
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Siraj razick 2008-06-03 07:39:34 PDT
QWebHitTestResult does not have an API function to get the boundingBox value from WebCore, I will attach a patch will that will expose the API function.
Comment 1 Siraj razick 2008-06-03 08:19:30 PDT
Created attachment 21477 [details]
Expose boundingBox value in QWebHitTestResult

Add API function QRect QWebHitResult::boundingBox() const
Comment 2 Siraj razick 2008-06-08 05:55:54 PDT
Comment on attachment 21477 [details]
Expose boundingBox value in QWebHitTestResult

Making obsolete till API documentation is added to the patch
Comment 3 Simon Hausmann 2008-10-21 15:30:36 PDT
Comment on attachment 21477 [details]
Expose boundingBox value in QWebHitTestResult

The patch looks good actually, it looks like we completly overlooked it :). Ariya added some API docs and I'm going to land it soon
Comment 4 Simon Hausmann 2008-10-21 15:33:31 PDT
Landed in r37764
Comment 5 Pierre-Luc Beaudoin 2008-10-21 15:54:53 PDT
I think you didn't overlook it, it wasn't "r?" :)
Comment 6 Siraj razick 2008-10-21 16:05:18 PDT
(In reply to comment #3)
> (From update of attachment 21477 [details] [edit])
> The patch looks good actually, it looks like we completly overlooked it :).
> Ariya added some API docs and I'm going to land it soon
> 
Thank you for the review + !and sorry for not adding the API docs. And Thank you Ariya for cleaning up the mess :) .
Comment 7 Simon Hausmann 2008-10-22 12:58:28 PDT
After a brief discussion we committed also r37787 that renames boundingBox() to boundingRect(), for consistency with the rest of the Qt API