Bug 19284 - Correct Windows (Cairo) Build Regressions
Summary: Correct Windows (Cairo) Build Regressions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-27 22:16 PDT by Brent Fulgham
Modified: 2008-05-29 04:29 PDT (History)
1 user (show)

See Also:


Attachments
Minor fixes for Cairo build (Windows) (5.89 KB, patch)
2008-05-27 23:18 PDT, Brent Fulgham
alp: review+
Details | Formatted Diff | Diff
Minor update to patch (using COMPILER(MSVC) guards). (5.97 KB, patch)
2008-05-28 09:54 PDT, Brent Fulgham
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2008-05-27 22:16:12 PDT
This patch corrects the following build regressions:

1.  Build regression due to r31830 (change of GraphicsContextPlatformPrivate::clip signature from IntRect to FloatRect.

2.  Correction due to r32781 (additional use of m_syntheticBoldOffset in GDI handling).
3.  Correct _setjmp build errors (warnings now handled as errors).
4.  Correct cURL build error (warning now handled as error) due to integral constant overflow.
Comment 1 Brent Fulgham 2008-05-27 23:18:31 PDT
Created attachment 21382 [details]
Minor fixes for Cairo build (Windows)
Comment 2 Alp Toker 2008-05-27 23:39:58 PDT
Comment on attachment 21382 [details]
Minor fixes for Cairo build (Windows)

The compiler-specific checks should be #if COMPILER(MSVC)

r=me otherwise.
Comment 3 Brent Fulgham 2008-05-28 09:54:52 PDT
Created attachment 21391 [details]
Minor update to patch (using COMPILER(MSVC) guards).
Comment 4 Alp Toker 2008-05-29 04:29:26 PDT
Landed in r34199.