Bug 19241 - Clean up SecurityOrigin::canAccess
Summary: Clean up SecurityOrigin::canAccess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-25 00:03 PDT by Adam Barth
Modified: 2008-05-26 13:13 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.19 KB, patch)
2008-05-25 00:05 PDT, Adam Barth 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2008-05-25 00:03:42 PDT 
Part of the comment in SecurityOrigin::canAccess refers to an old version of the code and should be removed.  Also, there is some code in the function that does nothing except look confusing.  It should be removed too.
Comment 1 Adam Barth 2008-05-25 00:05:37 PDT 
Created attachment 21331 [details]
patch

This patch should be functionally identical (except faster by avoiding some useless operations).
Comment 2 Sam Weinig 2008-05-25 08:30:40 PDT 
Comment on attachment 21331 [details]
patch

r=me!
Comment 3 Adam Barth 2008-05-26 13:13:42 PDT 
Fixed in r34137.