Bug 19186 - Remove usage of useQmake() from WebKitTools/Scripts
Summary: Remove usage of useQmake() from WebKitTools/Scripts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2008-05-22 06:13 PDT by Jan Alonzo
Modified: 2008-05-23 18:35 PDT (History)
0 users

See Also:


Attachments
Remove traces of useQmake (6.30 KB, patch)
2008-05-22 06:15 PDT, Jan Alonzo
no flags Details | Formatted Diff | Diff
Updated per Darin's review (6.41 KB, patch)
2008-05-23 17:32 PDT, Jan Alonzo
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Alonzo 2008-05-22 06:13:37 PDT
Since http://trac.webkit.org/changeset/33518 (removal of gtk-port stuff from the qmake build), useQmake is now unnecessary.
Comment 1 Jan Alonzo 2008-05-22 06:15:33 PDT
Created attachment 21292 [details]
Remove traces of useQmake

This patch removes traces of useQmake and just use isQt() if necessary. Also fixes a couple of typo ("Web Kit")
Comment 2 Darin Adler 2008-05-22 09:16:08 PDT
Comment on attachment 21292 [details]
Remove traces of useQmake

-$productDir .= "/Programs" if (isGtk() && not useQmake());

That change seems to change behavior since useQmake() was false before. Why is it OK to change behavior here?

Patch otherwise looks great.
Comment 3 Jan Alonzo 2008-05-23 17:32:21 PDT
Created attachment 21323 [details]
Updated per Darin's review

Hi Darin

Thanks. I added the line again and applied the same to run-webkit-tests.

Cheers
Comment 4 Darin Adler 2008-05-23 17:50:30 PDT
Comment on attachment 21323 [details]
Updated per Darin's review

r=me
Comment 5 Jan Alonzo 2008-05-23 18:35:29 PDT
Thanks. Landed in r34099