RESOLVED FIXED 19186
Remove usage of useQmake() from WebKitTools/Scripts 
https://bugs.webkit.org/show_bug.cgi?id=19186
Summary Remove usage of useQmake() from WebKitTools/Scripts
Jan Alonzo
Reported 2008-05-22 06:13:37 PDT
Since http://trac.webkit.org/changeset/33518 (removal of gtk-port stuff from the qmake build), useQmake is now unnecessary.
Attachments
Remove traces of useQmake (6.30 KB, patch)
2008-05-22 06:15 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
Updated per Darin's review (6.41 KB, patch)
2008-05-23 17:32 PDT, Jan Alonzo 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2008-05-22 06:15:33 PDT
Created attachment 21292 [details] Remove traces of useQmake This patch removes traces of useQmake and just use isQt() if necessary. Also fixes a couple of typo ("Web Kit")
Darin Adler
Comment 2 2008-05-22 09:16:08 PDT
Comment on attachment 21292 [details] Remove traces of useQmake -$productDir .= "/Programs" if (isGtk() && not useQmake()); That change seems to change behavior since useQmake() was false before. Why is it OK to change behavior here? Patch otherwise looks great.
Jan Alonzo
Comment 3 2008-05-23 17:32:21 PDT
Created attachment 21323 [details] Updated per Darin's review Hi Darin Thanks. I added the line again and applied the same to run-webkit-tests. Cheers
Darin Adler
Comment 4 2008-05-23 17:50:30 PDT
Comment on attachment 21323 [details] Updated per Darin's review r=me
Jan Alonzo
Comment 5 2008-05-23 18:35:29 PDT
Thanks. Landed in r34099
Note You need to log in before you can comment on or make changes to this bug.