WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
19172
WebCore::historyContains() appears to be dead and unnecessary code
https://bugs.webkit.org/show_bug.cgi?id=19172
Summary
WebCore::historyContains() appears to be dead and unnecessary code
Jonathon Jongsma (jonner)
Reported
2008-05-21 12:00:14 PDT
There is a FIXME comment in qwebhistoryinterface.cpp regarding the WebCore::historyContains() function. This function doesn't actually appear to be used anywhere, so it seems safe to just remove it.
Attachments
patch to remove the WebCore::historyContains() function and FIXME comment
(1.97 KB, patch)
2008-05-21 12:07 PDT
,
Jonathon Jongsma (jonner)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jonathon Jongsma (jonner)
Comment 1
2008-05-21 12:07:26 PDT
Created
attachment 21274
[details]
patch to remove the WebCore::historyContains() function and FIXME comment
Darin Adler
Comment 2
2008-05-21 12:11:29 PDT
Comment on
attachment 21274
[details]
patch to remove the WebCore::historyContains() function and FIXME comment r=me
Darin Adler
Comment 3
2008-06-03 14:02:11 PDT
Committed revision 34348.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug