Bug 19172 - WebCore::historyContains() appears to be dead and unnecessary code
Summary: WebCore::historyContains() appears to be dead and unnecessary code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P4 Trivial
Assignee: Jonathon Jongsma (jonner)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-21 12:00 PDT by Jonathon Jongsma (jonner)
Modified: 2008-06-03 14:02 PDT (History)
0 users

See Also:

Attachments
patch to remove the WebCore::historyContains() function and FIXME comment (1.97 KB, patch)
2008-05-21 12:07 PDT, Jonathon Jongsma (jonner) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathon Jongsma (jonner) 2008-05-21 12:00:14 PDT 
There is a FIXME comment in qwebhistoryinterface.cpp regarding the WebCore::historyContains() function.  This function doesn't actually appear to be used anywhere, so it seems safe to just remove it.
Comment 1 Jonathon Jongsma (jonner) 2008-05-21 12:07:26 PDT 
Created attachment 21274 [details]
patch to remove the WebCore::historyContains() function and FIXME comment
Comment 2 Darin Adler 2008-05-21 12:11:29 PDT 
Comment on attachment 21274 [details]
patch to remove the WebCore::historyContains() function and FIXME comment

r=me
Comment 3 Darin Adler 2008-06-03 14:02:11 PDT 
Committed revision 34348.