Bug 19163 - Tweak http/tests/security layout tests so they run on Firefox
Summary: Tweak http/tests/security layout tests so they run on Firefox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://crypto.stanford.edu/websec/cro...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-20 21:07 PDT by James Ren
Modified: 2008-05-26 16:59 PDT (History)
3 users (show)

See Also:

Attachments
Work-in-progress patch (36.99 KB, patch)
2008-05-20 21:12 PDT, James Ren 		no flags Details | Formatted Diff | Diff
patch (38.40 KB, patch)
2008-05-26 14:17 PDT, James Ren 		no flags Details | Formatted Diff | Diff
updated patch with comments from weinig and othermaciej (38.58 KB, patch)
2008-05-26 15:04 PDT, James Ren 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Ren 2008-05-20 21:07:00 PDT 
I've been working on running the WebKit security LayoutTests in Firefox.  I've implemented the LayoutTest controller for Firefox, but a few of the LayoutTests don't run to completion on Firefox.  This is usually because Firefox throws an exception when an access is forbidden, but WebKit logs to the error console.

We should tweak our security LayoutTests to run on Firefox.  I'll attach a patch shortly with the needed tweaks.
Comment 1 James Ren 2008-05-20 21:12:58 PDT 
Created attachment 21266 [details]
Work-in-progress patch

Here is a work-in-progress patch.
Comment 2 James Ren 2008-05-26 14:17:54 PDT 
Created attachment 21351 [details]
patch

Added a ChangeLog.
Added new expected results.
Comment 3 James Ren 2008-05-26 15:04:36 PDT 
Created attachment 21352 [details]
updated patch with comments from weinig and othermaciej

Removed tabs in ChangeLog
Added log messages for exceptions thrown when trying to get a cross-domain document.
Comment 4 James Ren 2008-05-26 16:59:44 PDT 
patch landed in 34142