Bug 19091 – Update CSS Transforms to latest spec

• Status: CLOSED
• Resolution: WONTFIX
• Component: CSS

[Dean Jackson]

This is the transforms part of http://bugs.webkit.org/show_bug.cgi?id=19028

[Dean Jackson]

Created attachment 21185 [details]
Updated transforms patch

> In Transform3D.cpp:
> 
> +Transform3D &Transform3D::function() {}
> 
> Move the & to be with the return value, so:
> 
> Transform3D& Transform3D::function() {}

done

> In CodeGeneratorObjC.pm:
> 
> I don't understand this:
> 
> -    return "CSSValue" if $parent eq "SVGColor";
> +    return "CSSValue" if $parent eq "SVGColor" or $parent eq "CSSValueList";

This is needed because the WebKitCSSTransformValue inherits from CSSValueList, which isn't recognised as a base class, and therefore gets Node as a parent. Code comes from Weinig.

> In DerivedSources.make:
> 
>   VoidCallback \
> +       WebKitCSSTransformValue \
>    WheelEvent \
> 
> Double-check if tabs are actually used in that file.

Removed, although there are some others in there that are not my fault :)


> I see "KeyframeList" in this patch.  I think that was unintentional.  Can you
> remove it?

Removed

[Dave Hyatt]

Comment on attachment 21185 [details]
Updated transforms patch

Only thing left that I see is the need to add new files to other projects to avoid breaking the build when landing.  You can edit them all by hand (the others are all text files and easy to patch blind).

Windows:
WebCore.vcproj/WebCore.vcproj

wx:
WebCore-sources.bkl

GTK:
GNUmakefile.am

Qt:
WebCore.pro

[Dean Jackson]

Created attachment 21189 [details]
adds the new files to non-OSX platforms

Here are the updated project files.

[Dean Jackson]

Created attachment 21234 [details]
Transforms patch with all platforms

This includes the IDL files, the JS constructors for use on Window and updates to all the platform build files. Hopefully, this is the real deal, yo!

[Dean Jackson]

Created attachment 21235 [details]
tests computed style of transform

[Dean Jackson]

Created attachment 21236 [details]
tests various transforms

[Dean Jackson]

Created attachment 21237 [details]
sets a transform property to a new cssmatrix

[Dean Jackson]

Created attachment 21238 [details]
tests transitions on transforms

[Dean Jackson]

Created attachment 21240 [details]
Transforms patch

Windows build fixes from aroben.

[Dave Hyatt]

Comment on attachment 21240 [details]
Transforms patch

r=me

[Darin Adler]

We should assign this to the person who's going to land it. Is that you, Hyatt?

[Dean Jackson]

got stale
now split across
https://bugs.webkit.org/show_bug.cgi?id=19861
https://bugs.webkit.org/show_bug.cgi?id=19863
https://bugs.webkit.org/show_bug.cgi?id=19864