font-family: initial sets font-family differently than font: initial

[David Kilzer (:ddkilzer)]

* SUMMARY
When using "font-family: initial" to style text, the font-family computed style differs from both using "font: initial" to style text and completely unstyled text.

* STEPS TO REPRODUCE
1. Launch Safari/WebKit.
2. Open attached test case.

* EXPECTED RESULTS
font-family: initial should have a computed font-family property value of "Times" (assuming the default Safari settings).

* ACTUAL RESULTS
font-family: initial has a computed font-family property value of "''" (that's two single quotes).

* REGRESSION
This is not a regression.  Safari 2.0.4 with original WebKit on Mac OS X 10.4.11 return the null value.

[David Kilzer (:ddkilzer)]

Created attachment 21173 [details]
Test case

[David Kilzer (:ddkilzer)]

<rdar://problem/5939391>

[David Kilzer (:ddkilzer)]

Created attachment 21175 [details]
Patch v1

Proposed patch and test case.

Instead of checking !initialDesc.firstFamily().familyIsEmpty() (which is always true for a new FontDescription()), the line that sets the family could just be removed.  I figured this was slightly safer in case the FontDescription default constructor changed in the future.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> Instead of checking !initialDesc.firstFamily().familyIsEmpty() (which is always
> true for a new FontDescription()), the line that sets the family could just be
> removed.  I figured this was slightly safer in case the FontDescription default
> constructor changed in the future.

I should say initialDesc.firstFamily().familyIsEmpty() is always true (meaning the first family is always empty for a new FontDescription()).

[Dave Hyatt]

Comment on attachment 21175 [details]
Patch v1

r=me

[David Kilzer (:ddkilzer)]

Committed revision 33496.