Bug 19051 - REGRESSION (r33447): Assertion in JSDebugServer::removeListener when closing tab with Inspector open
Summary: REGRESSION (r33447): Assertion in JSDebugServer::removeListener when closing ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P1 Normal
Assignee: Nobody
URL:
Keywords: Regression
: 19056 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-05-14 12:03 PDT by Matt Lilek
Modified: 2008-05-14 13:06 PDT (History)
2 users (show)

See Also:


Attachments
patch with ChangeLog (6.67 KB, patch)
2008-05-14 12:54 PDT, Adam Roben (:aroben)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2008-05-14 12:03:32 PDT
Closing a tab in r33447 crashes because of:

<http://trac.webkit.org/browser/trunk/WebCore/page/JavaScriptDebugServer.cpp#L109>
ARGUMENT BAD: page, page
(/Users/matt/Code/WebKit/WebCore/page/JavaScriptDebugServer.cpp:109 void WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*))

Thread 0 Crashed:
0   com.apple.WebCore             	0x02a20e42 WebCore::JavaScriptDebugServer::removeListener(WebCore::JavaScriptDebugListener*, WebCore::Page*) + 78 (JavaScriptDebugServer.cpp:109)
1   com.apple.WebCore             	0x025dc3bc WebCore::InspectorController::stopDebugging() + 38 (InspectorController.cpp:2076)
2   com.apple.WebCore             	0x025e098d WebCore::InspectorController::~InspectorController() + 347
3   com.apple.WebCore             	0x0271531e void WTF::deleteOwnedPtr<WebCore::InspectorController>(WebCore::InspectorController*) + 30 (OwnPtr.h:52)
4   com.apple.WebCore             	0x02715333 WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr() + 19
5   com.apple.WebCore             	0x02714410 WebCore::Page::~Page() + 462
6   com.apple.WebKit              	0x0022ff7d -[WebView(WebPrivate) _close] + 475 (WebView.mm:729)
Comment 1 Adam Roben (:aroben) 2008-05-14 12:54:34 PDT
Created attachment 21131 [details]
patch with ChangeLog
Comment 2 Dave Hyatt 2008-05-14 12:57:30 PDT
Comment on attachment 21131 [details]
patch with ChangeLog

r=me
Comment 3 Eric Seidel (no email) 2008-05-14 13:02:07 PDT
*** Bug 19056 has been marked as a duplicate of this bug. ***
Comment 4 Adam Roben (:aroben) 2008-05-14 13:06:46 PDT
Committed in r33450.