Bug 18962 – SQUIRRELFISH: ASSERT in JSGlobalObject::restoreLocalStorage

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Cameron Zwarich (cpst)]

Navigation will often cause assertion failures of the form:

ASSERTION FAILED: property->attributes() & ReadOnly == 0 && property->attributes() & DontEnum == 0
(/Users/Cameron/sf/JavaScriptCore/kjs/JSGlobalObject.cpp:167 void KJS::JSGlobalObject::restoreLocalStorage(const KJS::SavedProperties&))

A consistent way to trigger this is to attempt to load Gmail, wait for it to fail, and then use the HTML view. Clicking to view a message and then going back will trigger the assertion failure.

[Geoffrey Garen]

Merging with trunk will fix this, since trunk eliminates JSGlobalObject::restoreLocalStorage.

[Cameron Zwarich (cpst)]

(In reply to comment #1)
> Merging with trunk will fix this, since trunk eliminates
> JSGlobalObject::restoreLocalStorage.

I figured as much, but I just wanted to make sure there is a bug in the tracker for it. It will require slightly changing ownership on the SymbolTable, because the CodeBlock won't persist along with the JSGlobalObject.

[Geoffrey Garen]

Actually, the global object already owns the symbol table :).

[Cameron Zwarich (cpst)]

(In reply to comment #3)
> Actually, the global object already owns the symbol table :).

Oops, my bad. Isn't it great we always do things the right way from the beginning? ;-)